[ http://issues.apache.org/jira/browse/IBATIS-185?page=all ]
Clinton Begin closed IBATIS-185:
--------------------------------
Fix Version: 2.2.0
Resolution: Fixed
Assign To: Clinton Begin
Fixed as described. nice catch.
> SqlMapClasspathEntityResolver - Offline public ID resolution value ignored
> --------------------------------------------------------------------------
>
> Key: IBATIS-185
> URL: http://issues.apache.org/jira/browse/IBATIS-185
> Project: iBatis for Java
> Type: Bug
> Components: SQL Maps
> Versions: 2.1.5
> Environment: N/A
> Reporter: Jamison
> Assignee: Clinton Begin
> Priority: Trivial
> Fix For: 2.2.0
>
> I was browsing this code after having some resolution issues and noticed this
> code that looked a bit off:
> public InputSource resolveEntity(String publicId, String systemId)
> throws SAXException {
> InputSource source = null;
> try {
> String path = (String) doctypeMap.get(publicId); // Getting the public
> ID path
> path = (String) doctypeMap.get(systemId); //Whoops, I just burned over
> it without using it at all.
> if (path != null) {
> ...
> It hasn't caused me any trouble yet, but it does look suspicious. Should
> probably look like this, yeah?
> try {
> String path = (String) doctypeMap.get(systemId);
> if (path == null)
> path = (String) doctypeMap.get(publicId);
> if (path != null) {
> ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
