rdblue commented on a change in pull request #14: Pluggable file I/O submodule 
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r240415338
 
 

 ##########
 File path: 
core/src/main/java/com/netflix/iceberg/BaseMetastoreTableOperations.java
 ##########
 @@ -129,24 +132,13 @@ protected void refreshFromMetadataLocation(String 
newLocation, int numRetries) {
   }
 
   @Override
-  public InputFile newInputFile(String path) {
-    return fromLocation(path, conf);
+  public String resolveMetadataPath(String fileName) {
+    return newMetadataLocation(baseLocation, fileName);
 
 Review comment:
   Fair point. How about just `metadataFileLocation` then?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to