Also should the open PRs be announced on the mailing list? or is it a
matter of checking constantly on GitHub?
For example, in other projects new PRs are usually announced when posted
into JIRA.

El mié., 27 feb. 2019 a las 18:27, Ryan Blue (<rb...@netflix.com.invalid>)
escribió:

> Okay, let's amend my suggestion to say that the expectation is that the PR
> must be available for at least 2 days. Self +1 and merge in 2 minutes is a
> behavior that I would consider abusing the rule.
>
> If there are no other suggestions, I'll start a vote thread.
>
> On Wed, Feb 27, 2019 at 12:03 AM Anton Okolnychyi <aokolnyc...@apple.com>
> wrote:
>
>> +1 from me. As it was said, I think we need to reconsider this again once
>> Iceberg has more committers.
>>
>> On 27 Feb 2019, at 04:19, RD <rdsr...@gmail.com> wrote:
>>
>> +1
>>
>> On Tue, Feb 26, 2019 at 5:49 PM Jacques Nadeau <jacq...@dremio.com>
>> wrote:
>>
>>> I'm +1 (non-binding) if you allow a window for review (for example, I
>>> think others have suggested 1-2 business day before self+1). The post,
>>> self +1, merge in two minutes is not great situation for anyone.
>>> --
>>> Jacques Nadeau
>>> CTO and Co-Founder, Dremio
>>>
>>>
>>> On Tue, Feb 26, 2019 at 4:51 PM Ryan Blue <rb...@netflix.com.invalid>
>>> wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> I’d like to give a shout out to some of the awesome people that have
>>>> joined this community and taken the time to review pull requests: Matt
>>>> Cheah, Anton Okolnychyi, Ratandeep Ratti, Filip Bocse, and Uwe Korn. Thanks
>>>> to all of you!
>>>>
>>>> This work is really helpful to growing community and is a significant
>>>> step toward becoming a committer.
>>>>
>>>> Since we have such great community support, I’d like to suggest an
>>>> option for getting pull requests merged more quickly while we’re in the
>>>> current phase. We don’t have many committers to review pull requests, but
>>>> we do have several people on that path. I suggest we allow committers to
>>>> merge their own pull requests if they are reviewed by the community.
>>>>
>>>> I think this could be helpful, but I have seen it go wrong in the past
>>>> when people from the same company don’t make good faith reviews and instead
>>>> +1 a PR just to get it in. That said, I think we can address that problem
>>>> if and when it happens. We can also limit this policy to this year, after
>>>> which we should have more committers.
>>>>
>>>> What does everyone think?
>>>>
>>>> If there’s enough support on this thread, I’ll start a vote.
>>>>
>>>> rb
>>>> --
>>>> Ryan Blue
>>>> Software Engineer
>>>> Netflix
>>>>
>>>
>>
>
> --
> Ryan Blue
> Software Engineer
> Netflix
>

Reply via email to