Thanks, James. Is it possible for you to test with this patch? https://patch-diff.githubusercontent.com/raw/apache/incubator-iceberg/pull/986.patch
Those methods were removed, and it should be easy for Presto to update. That said, I don't like breaking downstream projects so it would be nice to fix it. I think this patch might. On Wed, Apr 29, 2020 at 1:12 PM James Taylor <jamestay...@apache.org> wrote: > Verified signature, checksum, rat checks, build, and unit tests. All > looked good. Tried building latest prestosql master with proposed new > iceberg release, but received these compilation errors: > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile > (default-compile) on project presto-iceberg: Compilation failure: > Compilation failure: > [ERROR] > /Users/jamestaylor/dev/presto/presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/IcebergMetadata.java:[359,34] > method newTableMetadata in class org.apache.iceberg.TableMetadata cannot be > applied to given types; > [ERROR] required: > org.apache.iceberg.Schema,org.apache.iceberg.PartitionSpec,java.lang.String,java.util.Map<java.lang.String,java.lang.String> > [ERROR] found: > org.apache.iceberg.TableOperations,org.apache.iceberg.Schema,org.apache.iceberg.PartitionSpec,java.lang.String,com.google.common.collect.ImmutableMap<java.lang.String,java.lang.String> > [ERROR] reason: actual and formal argument lists differ in length > [ERROR] > /Users/jamestaylor/dev/presto/presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/HiveTableOperations.java:[301,44] > no suitable method found for > read(io.prestosql.plugin.iceberg.HiveTableOperations,org.apache.iceberg.io.InputFile) > [ERROR] method > org.apache.iceberg.TableMetadataParser.read(org.apache.iceberg.io.FileIO,java.lang.String) > is not applicable > [ERROR] (argument mismatch; > io.prestosql.plugin.iceberg.HiveTableOperations cannot be converted to > org.apache.iceberg.io.FileIO) > [ERROR] method > org.apache.iceberg.TableMetadataParser.read(org.apache.iceberg.io.FileIO,org.apache.iceberg.io.InputFile) > is not applicable > [ERROR] (argument mismatch; > io.prestosql.plugin.iceberg.HiveTableOperations cannot be converted to > org.apache.iceberg.io.FileIO) > > Is this a showstopper? Probably a simple PR in presto would fix it, but > unclear if b/w compatibility is a goal or not. > > Thanks, > James > > On Tue, Apr 28, 2020 at 1:40 PM Ryan Blue <b...@apache.org> wrote: > >> Hi everyone, >> >> I propose the following RC to be released as official Apache Iceberg >> 0.8.0-incubating release. >> >> The commit id is 4c2dd0ac2c832cc425b33d3b578025fa4e295392 >> * This corresponds to the tag: apache-iceberg-0.8.0-incubating-rc1 >> * >> https://github.com/apache/incubator-iceberg/commits/apache-iceberg-0.8.0-incubating-rc1 >> * https://github.com/apache/incubator-iceberg/tree/4c2dd0ac >> >> The release tarball, signature, and checksums are here: >> * >> https://dist.apache.org/repos/dist/dev/incubator/iceberg/apache-iceberg-0.8.0-incubating-rc1/ >> >> You can find the KEYS file here: >> * https://dist.apache.org/repos/dist/dev/incubator/iceberg/KEYS >> >> Convenience binary artifacts are staged in Nexus. The Maven repository >> URL is: >> * >> https://repository.apache.org/content/repositories/orgapacheiceberg-1005/ >> >> This release contains many bug fixes and several new features: >> * Actions to remove orphaned files and to optimize metadata for query >> performance >> * Support for ORC data files >> * Snapshot cherry-picking >> * Incremental scan planning based on table history >> * In and notIn expressions >> * An InputFormat for writing MR jobs >> >> Please download, verify, and test. >> >> Please vote in the next 72 hours. >> >> [ ] +1 Release this as Apache Iceberg 0.8.0-incubating >> [ ] +0 >> [ ] -1 Do not release this because... >> >> >> -- >> Ryan Blue >> > -- Ryan Blue Software Engineer Netflix
