Thanks to everyone who participated in the vote for Release Apache Iceberg 0.13.0 RC1.
The vote result is: +1: 0 (binding), 1 (non-binding) +0: 0 (binding), 0 (non-binding) -1: 1 (binding), 0 (non-binding) Therefore, the release candidate is rejected. For the shasum and gpg key issue John reported, it turns out there are multiple bugs in the current source-release.sh script: 1. gpg key input is not respected by the script and the default key is used instead of the key in the input, which is a different key from my code signing key on my machine 2. shasum uses the absolute path instead of relative path for checksum output I am raising a PR to fix both issues, and I will re-cut a new RC after the fix. Best, Jack Ye On Thu, Jan 27, 2022 at 12:52 PM Anton Okolnychyi <aokolnyc...@apple.com.invalid> wrote: > -1 as I found a correctness bug in the cardinality check for MERGE in > Spark when shuffle hash and broadcast nested loop joins are used. It was > introduced recently in our Spark 3.2 integration (does NOT affect Spark 3.0 > and 3.1). > > Here is a PR to fix it: > https://github.com/apache/iceberg/pull/3992 > > - Anton > > On 27 Jan 2022, at 10:07, John Zhuge <jzh...@apache.org> wrote: > > Should the sha512 file contain the file name not the full path? > > $ cat apache-iceberg-0.13.0.tar.gz.sha512 > 6e53a5dd680ea43ee555c4541135cabcfec9b00fdefcb690859d3cda5f20edcc07fbe29b4bb500720f2aa5d1c1639dbff53ce7bf337e0c3e48aa970fcf0df7e7 > > /Users/yzhaoqin/workspaces/oss/src/YzhaoqinOSS/projects/iceberg_apache/apache-iceberg-0.13.0.tar.gz > > > $ shasum -c *sha512 > shasum: > /Users/yzhaoqin/workspaces/oss/src/YzhaoqinOSS/projects/iceberg_apache/apache-iceberg-0.13.0.tar.gz: > No such file or directory > /Users/yzhaoqin/workspaces/oss/src/YzhaoqinOSS/projects/iceberg_apache/apache-iceberg-0.13.0.tar.gz: > FAILED open or read > shasum: WARNING: 1 listed file could not be read > > On Thu, Jan 27, 2022 at 10:05 AM John Zhuge <jzh...@apache.org> wrote: > >> After importing keys from >> https://dist.apache.org/repos/dist/dev/iceberg/KEYS, failed to verify >> the signature: >> >> [apache-iceberg-0.13.0-rc1]$ ls >> KEYS apache-iceberg-0.13.0.tar.gz apache-iceberg-0.13.0.tar.gz.asc >> apache-iceberg-0.13.0.tar.gz.sha512 >> >> [apache-iceberg-0.13.0-rc1]$ gpg --verify apache-iceberg-0.13.0.tar.gz.asc >> gpg: assuming signed data in 'apache-iceberg-0.13.0.tar.gz' >> gpg: Signature made Tue Jan 25 00:59:14 2022 PST >> gpg: using RSA key 75C058D19F7F5D94E05D982291DA080263D3E7A4 >> gpg: Can't check signature: No public key >> >> >> On Wed, Jan 26, 2022 at 5:51 PM Nan Zhu <zhunanmcg...@gmail.com> wrote: >> >>> tested with internal cases with some focus on a few changes we made in >>> this version, looks good from my perspective >>> >>> +1 >>> >>> On Tue, Jan 25, 2022 at 4:08 PM Kyle Bendickson <k...@tabular.io> wrote: >>> >>>> Thank you, Jack! >>>> >>>> Quick announcement when testing: *the runtime jars / artifacts for >>>> Spark & Flink have changed naming format *to include the corresponding >>>> Spark / Flink version. The Spark jars also have the Scala version appended >>>> at the end. >>>> >>>> *Spark:* >>>> You can test the 0.13.0-rc1, fetching it from the staging maven >>>> repository, with the following command line flags for Spark 3.2: >>>> `--packages 'org.apache.iceberg:iceberg-spark-runtime-3.2_2.12:0.13.0' >>>> --repositories >>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1079/` >>>> <https://repository.apache.org/content/repositories/orgapacheiceberg-1079/> >>>> >>>> For other Spark versions than 3.2, use the artifactIds below (in place >>>> of `iceberg-spark-runtime-3.2_2.12` above). >>>> >>>> *iceberg-spark-runtime artifact names as of 0.13.0:* >>>> Spark 3.0: `iceberg-spark3-runtime:0.13.0` >>>> Spark 3.1: `iceberg-spark-runtime-3.1_2.12` >>>> Spark 3.2: `iceberg-spark-runtime-3.2_2.12` >>>> >>>> The complete package name for any depends on your spark version now. >>>> `iceberg-spark3-runtime` should only be used for Spark 3.0. >>>> >>>> *Flink:* >>>> *iceberg-flink-runtime artifact names as of 0.13.0:* >>>> 1.12: iceberg-flink-runtime-1.12 >>>> 1.13: iceberg-flink-runtime-1.13 >>>> 1.14: iceberg-flink-runtime-1.14 >>>> >>>> Thank you and happy testing! >>>> - Kyle >>>> >>>> >>>> >>>> On Tue, Jan 25, 2022 at 9:09 AM Jack Ye <yezhao...@gmail.com> wrote: >>>> >>>>> Hi Everyone, >>>>> >>>>> I propose that we release the following RC as the official Apache >>>>> Iceberg 0.13.0 release. >>>>> >>>>> The commit ID is ca8bb7d0821f35bbcfa79a39841be8fb630ac3e5 >>>>> * This corresponds to the tag: apache-iceberg-0.13.0-rc1 >>>>> * https://github.com/apache/iceberg/commits/apache-iceberg-0.13.0-rc1 >>>>> * >>>>> https://github.com/apache/iceberg/tree/ca8bb7d0821f35bbcfa79a39841be8fb630ac3e5 >>>>> >>>>> The release tarball, signature, and checksums are here: >>>>> * >>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-0.13.0-rc1 >>>>> >>>>> You can find the KEYS file here: >>>>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>>> >>>>> Convenience binary artifacts are staged on Nexus. The Maven repository >>>>> URL is: >>>>> * >>>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1079/ >>>>> >>>>> Please download, verify, and test. >>>>> >>>>> Please vote in the next 72 hours. >>>>> >>>>> [ ] +1 Release this as Apache Iceberg 0.13.0 >>>>> [ ] +0 >>>>> [ ] -1 Do not release this because... >>>>> >>>> >> >> -- >> John Zhuge >> > > > -- > John Zhuge > > >
