[GitHub] [iceberg] rdblue commented on a diff in pull request #4469: Spark 3.2: Refactor certain actions

[GitBox]

rdblue commented on code in PR #4469:
URL: https://github.com/apache/iceberg/pull/4469#discussion_r841274787


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteReachableFilesSparkAction.java:
##########
@@ -103,53 +87,46 @@ public DeleteReachableFiles io(FileIO fileIO) {
 
   @Override
   public DeleteReachableFiles deleteWith(Consumer<String> deleteFunc) {
-    this.removeFunc = deleteFunc;
+    this.deleteFunc = deleteFunc;
     return this;
-
   }
 
   @Override
   public DeleteReachableFiles executeDeleteWith(ExecutorService 
executorService) {
-    this.removeExecutorService = executorService;
+    this.deleteExecutorService = executorService;
     return this;
   }
 
   @Override
   public Result execute() {
-    Preconditions.checkArgument(io != null, "File IO cannot be null");

Review Comment:
   I see no reason not to leave it in though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org