No problem! Thanks for contributing and helping to keep the code clean. On Tue, Nov 1, 2022 at 4:58 PM Pavan Lanka <[email protected]> wrote:
> Hi Ryan, > > Wanted a follow up on this one. > > Earlier I missed this contribution from Kyle. > > SPARK: Allow spark catalogs to have hadoop configuration overrides p…… · > apache/iceberg@1b3dbb6 > <https://github.com/apache/iceberg/commit/1b3dbb6f13110eb734488d32e93e0fa8d23e9385> > github.com > <https://github.com/apache/iceberg/commit/1b3dbb6f13110eb734488d32e93e0fa8d23e9385> > [image: apple-touch-icon-180x180.png] > <https://github.com/apache/iceberg/commit/1b3dbb6f13110eb734488d32e93e0fa8d23e9385> > <https://github.com/apache/iceberg/commit/1b3dbb6f13110eb734488d32e93e0fa8d23e9385> > > This gives us sufficient options to even provide Hive overrides using the > same approach, which makes this patch redundant or at a minimum not in line > with this other contribution. I will send out a PR reverting this patch. > > Sorry for the double work on this. > > Thanks, > Pavan > > On Oct 20, 2022, at 9:48 AM, Ryan Blue <[email protected]> wrote: > > Thanks, Pavan. I just took a look. There's a small nit with formatting but > overall I think it looks good. > > On Thu, Oct 20, 2022 at 8:21 AM Pavan Lanka <[email protected]> > wrote: > >> Hi, >> >> I have raised an issue regarding the means for configuring the >> HiveMetastoreClient to allow for different properties while connection to >> different metastore services. >> >> https://github.com/apache/iceberg/issues/5988 >> >> I also have a PR for the same that takes any catalog properties starting >> with `hive` and uses them in the configuration of the Metastore client. >> >> https://github.com/apache/iceberg/pull/5989 >> >> Would be great to get some eyes on the PR. Please do let me know if I can >> ease this process in anyway.te >> Thanks, >> Pavan >> > > > -- > Ryan Blue > Tabular > > > -- Ryan Blue Tabular
