Hey everyone! First of all, happy thanksgiving!
+1 (non-binding) It looks good now on the Trino side. Still some tests are failing <https://github.com/trinodb/trino/pull/15079>, but that's explainable. As an example, the following test is still failing: https://github.com/trinodb/trino/blob/ed2f14ce92a67fd5c951d6258a2d1e9d4540d546/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMetadataFileOperations.java#L229-L241 With the output: Expecting: <[FileOperation{fileType=SNAPSHOT, operationType=INPUT_FILE_GET_LENGTH}, FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_GET_LENGTH}, FileOperation{fileType=SNAPSHOT, operationType=INPUT_FILE_NEW_STREAM}, FileOperation{fileType=METADATA_JSON, operationType=INPUT_FILE_NEW_STREAM}, FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_NEW_STREAM}]> to contain exactly in any order: <[FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_GET_LENGTH}, FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_GET_LENGTH}, FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_NEW_STREAM}, FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_NEW_STREAM}, FileOperation{fileType=METADATA_JSON, operationType=INPUT_FILE_NEW_STREAM}, FileOperation{fileType=SNAPSHOT, operationType=INPUT_FILE_GET_LENGTH}, FileOperation{fileType=SNAPSHOT, operationType=INPUT_FILE_NEW_STREAM}]> but could not find the following elements: <[FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_GET_LENGTH}, FileOperation{fileType=MANIFEST, operationType=INPUT_FILE_NEW_STREAM}]> It looks like we're reading fewer manifests. After running a git bisect, I narrowed it down to this PR: https://github.com/apache/iceberg/pull/5632, which is an optimization that makes perfect sense. Kind regards, Fokko Driesprong Op wo 23 nov. 2022 om 17:15 schreef Eduard Tudenhoefner <edu...@tabular.io>: > +1 (non-binding) > > - validated checksum and signature > - checked license docs & ran RAT checks > - ran build and tests with JDK11 > - integrated 1.1.0 RC4 into Presto > <https://github.com/prestodb/presto/pull/18709> > > > > On Wed, Nov 23, 2022 at 9:14 AM Ajantha Bhat <ajanthab...@gmail.com> > wrote: > >> +1 (non-binding) >> >> - verified tests against spark-3.3 runtime jar with Nessie catalog. >> - verified the contents of the iceberg-spark-runtime-3.3_2.12-1.1.0.jar >> - checked for spark-3.0 removal >> - validated checksum and signature >> - checked license docs & ran RAT checks >> - ran build with JDK1.8 >> >> Thanks, >> Ajantha >> >> On Tue, Nov 22, 2022 at 9:49 PM Gabor Kaszab <gaborkas...@apache.org> >> wrote: >> >>> Hi Everyone, >>> >>> I propose that we release the following RC as the official Apache Iceberg >>> 1.1.0 release. >>> >>> The commit ID is ede085d0f7529f24acd0c81dd0a43f7bb969b763 >>> * This corresponds to the tag: apache-iceberg-1.1.0-rc4 >>> * https://github.com/apache/iceberg/commits/apache-iceberg-1.1.0-rc4 >>> * >>> https://github.com/apache/iceberg/tree/ede085d0f7529f24acd0c81dd0a43f7bb969b763 >>> >>> The release tarball, signature, and checksums are here: >>> * https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.1.0-rc4 >>> >>> You can find the KEYS file here: >>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>> >>> Convenience binary artifacts are staged on Nexus. The Maven repository URL >>> is: >>> * https://repository.apache.org/content/repositories/orgapacheiceberg-1114/ >>> >>> Please download, verify, and test. >>> >>> Please vote in the next 72 hours. >>> >>> [ ] +1 Release this as Apache Iceberg 1.1.0 >>> [ ] +0 >>> [ ] -1 Do not release this because... >>> >>>
