+1 to relocate with history. On Sat, Sep 30, 2023, 10:24 AM Brian Olsen <bitsondata...@gmail.com> wrote:
> This shouldn’t be too hard and can likely be a nightly build that occurs > with each client repository. > > We’re already planning on doing the documentation using git submodule to > pull all the documentation under a single build in the central repo. We can > likely go the other direction to run client-core integration tests. I > prefer these go on the client end to avoid too much ci running on the core > repo. We have to also consider whatever we choose to do with Python client > we will also apply to go, Rust, and any future client. Happy to hear > alternatives though! > > WDYT Fokko? > > > > On Sat, Sep 30, 2023 at 7:12 AM Hussein Awala <huss...@awala.fr> wrote: > >> +1 >> >> I checked the discussion thread, and one of the motivations for this >> separation was to avoid triggering unrelated CI jobs after each change. >> However, I wonder if it isn't (and will not be) necessary to check the >> compatibility between the main repository and the client after each change. >> Otherwise, we will need to trigger the CI across the different repositories >> using the GHA API, not necessarily to block the PR, but just to give quick >> feedback and notification that something needs to be changed on the client >> side. >> >> On Fri, Sep 29, 2023 at 9:39 PM Brian Olsen <bitsondata...@gmail.com> >> wrote: >> >>> +1 >>> >>> Great work Fokko! >>> >>> Pucheng, >>> >>> We still want to maintain all of the issues in the Python repository. >>> The one thing we will lose is pull requests, but I assume there are very >>> few. >>> >>> On Fri, Sep 29, 2023 at 10:34 AM Pucheng Yang >>> <py...@pinterest.com.invalid> wrote: >>> >>>> Thanks for doing this. I wonder how do we deal with all the issues >>>> filed for python module but still open in iceberg repo? >>>> >>>> On Fri, Sep 29, 2023 at 7:55 AM Eduard Tudenhoefner <edu...@tabular.io> >>>> wrote: >>>> >>>>> +1 on moving to a separate repo and maintaining git history >>>>> >>>>> On Fri, Sep 29, 2023 at 3:30 PM Jean-Baptiste Onofré <j...@nanthrax.net> >>>>> wrote: >>>>> >>>>>> Awesome, it looks even better ;) >>>>>> >>>>>> Thanks ! >>>>>> Regards >>>>>> JB >>>>>> >>>>>> On Fri, Sep 29, 2023 at 2:31 PM Fokko Driesprong <fo...@apache.org> >>>>>> wrote: >>>>>> > >>>>>> > Hey Ajantha, >>>>>> > >>>>>> > That's a great suggestion. I've followed the steps and created a >>>>>> new PR here: https://github.com/apache/iceberg-python/pull/3 >>>>>> > >>>>>> > The subdirectory-filter command moves a subdirectory to the root >>>>>> directory. This way I still had to add some files afterward (.github/*, >>>>>> .gitignore, etc.), these are in a separate commit. Please take a look. >>>>>> > >>>>>> > Thanks, >>>>>> > >>>>>> > Fokko >>>>>> > >>>>>> > Op vr 29 sep 2023 om 13:39 schreef Ajantha Bhat < >>>>>> ajanthab...@gmail.com>: >>>>>> >> >>>>>> >> I think we are gonna lose the history of commits if we merge the >>>>>> above PR. >>>>>> >> >>>>>> >> There are ways to move the subfolder into a new repo by retaining >>>>>> commit history. >>>>>> >> For example: >>>>>> >> - >>>>>> https://medium.com/@ayushya/move-directory-from-one-repository-to-another-preserving-git-history-d210fa049d4b >>>>>> >> - https://gist.github.com/trongthanh/2779392 >>>>>> >> >>>>>> >> Please give it a try. >>>>>> >> >>>>>> >> Thanks, >>>>>> >> Ajantha >>>>>> >> >>>>>> >> On Fri, Sep 29, 2023 at 4:55 PM Fokko Driesprong <fo...@apache.org> >>>>>> wrote: >>>>>> >>> >>>>>> >>> Hey everyone 👋 >>>>>> >>> >>>>>> >>> A while ago we discussed that Rust and Go are going into a >>>>>> separate repository: >>>>>> https://lists.apache.org/thread/4s02lmwf1kyrxxdpj3q9w2fqnxq2llbn >>>>>> >>> >>>>>> >>> Since we just did the PyIcerg 0.5.0 release, I think it is a good >>>>>> moment to migrate PyIceberg to iceberg-python as well: >>>>>> https://github.com/apache/iceberg-python/pull/2 I went over the PRs >>>>>> that are ready to merge and got them in. If there is anything missing, >>>>>> please let me know. >>>>>> >>> >>>>>> >>> I would suggest merging the PR and leaving the source code in the >>>>>> main repository for another week or so to make sure that we didn't miss >>>>>> anything. >>>>>> >>> >>>>>> >>> Since PyIceberg now also hosts the docs on the Github pages of >>>>>> the Iceberg repository, moving PyIceberg will also free up the Github >>>>>> pages >>>>>> for the migration of the docs back into the main repository. >>>>>> >>> >>>>>> >>> Let me know if there are any concerns. >>>>>> >>> >>>>>> >>> Kind regards, >>>>>> >>> Fokko Driesprong >>>>>> >>>>>
