Fokko found one issue when using *USE <namespace>* and then *SHOW VIEWS *(without specifying a namespace) with the *RESTCatalog*. While we actually test this in *TestViews *using the *InMemoryCatalog* and things don't fail and behave as expected, that same behavior fails when using *RESTCatalog*. It turns out that the namespace check in the *InMemoryCatalog* is wrong when dealing with an empty namespace, and so that issue went unnoticed with the *InMemoryCatalog.*
That being said, we have two bugs * *SHOW VIEWS* need to use the currently defined namespace when it's executed without a namespace * *InMemoryCatalog* needs to correctly deal with empty namespace I should have PRs ready in a bit but we'll probably do another RC. Eduard On Fri, Feb 23, 2024 at 6:32 AM Amogh Jahagirdar <am...@tabular.io> wrote: > +1 non-binding. > > Ran signature, checksum, license checks and build/test with JDK11 > Ran tests with views in Spark3.5/Spark3.4 and Trino with REST/JDBC catalog. > > Thanks, > > Amogh Jahagirdar > > On Thu, Feb 22, 2024 at 9:10 PM Jack Ye <yezhao...@gmail.com> wrote: > >> +1 (binding) >> >> Checked license, signature, checksum, build, test with Java17 >> Ran manual test with EMR 7.0 Spark 3.5 and Glue. >> >> Best, >> Jack Ye >> >> On Thu, Feb 22, 2024 at 7:58 PM Daniel Weeks <dwe...@apache.org> wrote: >> >>> +1 (binding) >>> >>> Verified sigs/sums/license/build/test (Java 17) >>> >>> I also did manual verification of view features using jdbc catalog >>> (postgresql). >>> >>> -Dan >>> >>> >>> On Thu, Feb 22, 2024 at 6:38 AM Jean-Baptiste Onofré <j...@nanthrax.net> >>> wrote: >>> >>>> Correction, my vote is non-binding >>>> >>>> Regards >>>> JB >>>> >>>> On Thu, Feb 22, 2024 at 10:07 AM Jean-Baptiste Onofré <j...@nanthrax.net> >>>> wrote: >>>> > >>>> > +1 (binding) >>>> > >>>> > I checked: >>>> > - signatures and checksum are OK >>>> > - ASF license headers >>>> > - no binary file found in the source distribution >>>> > - LICENSE/NOTICE are OK (regarding the discussion we had :) ) >>>> > - Build OK with JDK11 >>>> > - Tested JdbcCatalog (with different schema version) with PostgreSQL >>>> backend >>>> > - Tested JdbcCatalog with Trino >>>> > >>>> > Thanks ! >>>> > Regards >>>> > JB >>>> > >>>> > On Thu, Feb 22, 2024 at 12:38 AM Drew <img...@gmail.com> wrote: >>>> > > >>>> > > +1 (non-binding) >>>> > > >>>> > > - verified signature and checksum >>>> > > - verified RAT license check >>>> > > - verified build/tests passing with JDK17 >>>> > > - ran manual tests with GlueCatalog on Spark 3.5 >>>> > > >>>> > > Drew >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > On Wed, Feb 21, 2024 at 9:33 AM Ajantha Bhat <ajanthab...@gmail.com> >>>> wrote: >>>> > >> >>>> > >> Hi Everyone, >>>> > >> >>>> > >> I propose that we release the following RC as the official Apache >>>> Iceberg 1.5.0 release. >>>> > >> >>>> > >> The commit ID is 0c8703078443a3c73a5aa5a6bd1cf904e0b5ce09 >>>> > >> * This corresponds to the tag: apache-iceberg-1.5.0-rc3 >>>> > >> * >>>> https://github.com/apache/iceberg/commits/apache-iceberg-1.5.0-rc3 >>>> > >> * >>>> https://github.com/apache/iceberg/tree/0c8703078443a3c73a5aa5a6bd1cf904e0b5ce09 >>>> > >> >>>> > >> The release tarball, signature, and checksums are here: >>>> > >> * >>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.5.0-rc3 >>>> > >> >>>> > >> You can find the KEYS file here: >>>> > >> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>> > >> >>>> > >> Convenience binary artifacts are staged on Nexus. The Maven >>>> repository URL is: >>>> > >> * >>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1153/ >>>> > >> >>>> > >> Please download, verify, and test. >>>> > >> >>>> > >> Please vote in the next 72 hours. >>>> > >> >>>> > >> [ ] +1 Release this as Apache Iceberg 1.5.0 >>>> > >> [ ] +0 >>>> > >> [ ] -1 Do not release this because... >>>> > >> >>>> > >> Only PMC members have binding votes, but other community members >>>> are encouraged to cast >>>> > >> non-binding votes. This vote will pass if there are 3 binding +1 >>>> votes and more binding >>>> > >> +1 votes than -1 votes. >>>> > >> >>>> > >> - Ajantha >>>> >>>
