+1 (non binding) Downloaded specific commit from the repo, and ran both the Python tests and integration tests.
Steps: ``` git clone --depth=1 --branch pyiceberg-0.6.1rc2 g...@github.com: apache/iceberg-python.git python -m venv ./venv source ./venv/bin/activate make install make test make test-integration ``` Also ran into the issue Dan mentioned, subsequent `make install` ran successfully. Here's the stack trace: ``` Preparing build environment with build-system requirements poetry-core>=1.0.0, wheel, Cython>=3.0.0, setuptools Command ['/var/folders/f1/3_vzsn7x1jq9hszb3z9y6f0m0000gn/T/tmph283p6rj/.venv/bin/python', '/private/tmp/iceberg-python/venv/lib/python3.11/site-packages/virtualenv/seed/wheels/embed/pip-24.0-py3-none-any.whl/pip', 'install', '--disable-pip-version-check', '--ignore-installed', '--no-input', 'poetry-core>=1.0.0', 'wheel', 'Cython>=3.0.0', 'setuptools'] errored with the following return code 2 Output: /var/folders/f1/3_vzsn7x1jq9hszb3z9y6f0m0000gn/T/tmph283p6rj/.venv/bin/python: can't open file '/private/tmp/iceberg-python/venv/lib/python3.11/site-packages/virtualenv/seed/wheels/embed/pip-24.0-py3-none-any.whl/pip': [Errno 2] No such file or directory make: *** [install-dependencies] Error 1 ``` Thanks, Kevin On Wed, Apr 17, 2024 at 3:06 PM Daniel Weeks <dwe...@apache.org> wrote: > I tried running the verification process but ran into issues resolving > some of the dependencies: > > make install > Updating dependencies > Resolving dependencies... (3.1s) > > Package docutils (0.21.post1) not found. > make: *** [install-dependencies] Error 1 > > I found this related issue > <https://github.com/python-poetry/poetry/issues/9293#issuecomment-2048205226> > which indicates pip is trying to install a "post release" version. > > This was with python 3.10 and pip 22.0.4 > > I haven't been able to get the install to properly resolve the dependencies > > -Dan > > > On Wed, Apr 17, 2024 at 2:10 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > >> +1 (non binding) >> >> I checked: >> - Hash and signature are good >> - LICENSE and NOTICE look good >> - No binary file found in the source distribution >> - Ran a few tests >> >> Regards >> JB >> >> On Tue, Apr 16, 2024 at 4:53 AM Honah J. <hon...@apache.org> wrote: >> > >> > Hi Everyone, >> > >> > I propose that we release the following RC as the official PyIceberg >> 0.6.1 release. >> > >> > This is a patch release due to the following bugs: >> > >> > Fail to create version 1 table with non-empty partition-spec and >> sort-order >> > Hive Catalog cannot create table with TimestamptzType field >> > Fail to read parquet file with special characters in column names >> > Hive Catalog commit consistency issue >> > >> > Smaller bugs also have been backported. >> > >> > The commit ID is 0161e5c6b9bea2b6cf47245efd8df85da2c3d9b0 >> > >> > * This corresponds to the tag: pyiceberg-0.6.1rc2 >> (139fdff1ff6cff97264a61db8e9ed9ee3520d6d2) >> > * >> https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.6.1rc2 >> > * >> https://github.com/apache/iceberg-python/tree/0161e5c6b9bea2b6cf47245efd8df85da2c3d9b0 >> > >> > The release tarball, signature, and checksums are here: >> > >> > * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.6.1rc2/ >> > >> > You can find the KEYS file here: >> > >> > * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >> > >> > Convenience binary artifacts are staged on pypi: >> > >> > https://pypi.org/project/pyiceberg/0.6.1rc2/ >> > >> > And can be installed using: pip3 install pyiceberg==0.6.1rc2 >> > >> > Please download, verify, and test. >> > >> > Please vote in the next 72 hours. >> > [ ] +1 Release this as PyIceberg 0.6.1 >> > [ ] +0 >> > [ ] -1 Do not release this because... >> >
