Thanks Sung! I agree with the comments that this doesn't require a new RC.
+1 (binding) Verified sigs/sums/license/build/test with Python 3.11.9 Thanks, -Dan On Thu, Aug 15, 2024 at 3:34 PM Sung Yun <sungwy...@gmail.com> wrote: > Hi Daniel, thank you very much for testing the installation thoroughly and > reporting these issues. > > We make note of the supported Python versions using the PyPi classifiers > <https://github.com/apache/iceberg-python/blob/9e27d59e51e80049d39e72586a932cd561cdd092/pyproject.toml#L26-L33>, > but I agree that we should include the restriction in the installation > requirements as well. > > Here's a PR with an attempt to fix the this issue, and the issue with > docutils (0.21.post1): https://github.com/apache/iceberg-python/pull/1067 > > On Thu, Aug 15, 2024 at 5:35 PM Daniel Weeks <dwe...@apache.org> wrote: > >> I ran into a couple issues while trying to verify the release. >> >> The first appears to be a transient issue (we ran into something similar >> in the 0.6.1 release but I was able to install later). >> >> Package docutils (0.21.post1) not found. >> make: *** [install-dependencies] Error 1 >> >> The second issue is more concerning to me because I can't install >> dependencies with Python 3.12.4 as I get the following: >> >> - Installing numpy (1.24.4): Failed >> >> ChefBuildError >> >> Backend 'setuptools.build_meta:__legacy__' is not available. >> >> Cannot import 'setuptools.build_meta' >> >> at venv/lib/python3.12/site-packages/poetry/installation/chef.py:164 in >> _prepare >> 160│ >> 161│ error = >> ChefBuildError("\n\n".join(message_parts)) >> 162│ >> 163│ if error is not None: >> → 164│ raise error from None >> 165│ >> 166│ return path >> 167│ >> 168│ def _prepare_sdist(self, archive: Path, destination: Path >> | None = None) -> Path: >> >> Note: This error originates from the build backend, and is likely not a >> problem with poetry but with numpy (1.24.4) not supporting PEP 517 builds. >> You can verify this by running 'pip wheel --no-cache-dir --use-pep517 >> "numpy (==1.24.4)"'. >> >> I was able to verify everything with 3.11 however, but I haven't seen >> anything that would indicate we don't support 3.12.x >> >> -Dan >> >> On Wed, Aug 14, 2024 at 7:14 PM Kevin Liu <kevin.jq....@gmail.com> wrote: >> >>> +1 (non-binding) >>> Verified signatures/checksums/licenses. Ran unit and integration tests. >>> >>> On Thu, Aug 15, 2024 at 2:42 AM Fokko Driesprong <fo...@apache.org> >>> wrote: >>> >>>> +1 (binding) >>>> >>>> Thanks Sung for running this 🙌 >>>> >>>> - Validated signatures/checksums/license >>>> - Ran some basic tests (3.10) >>>> >>>> Kind regards, >>>> Fokko >>>> >>>> Op wo 14 aug 2024 om 19:57 schreef André Luis Anastácio >>>> <ndrl...@proton.me.invalid>: >>>> >>>>> >>>>> - validated signatures and checksums >>>>> >>>>> >>>>> - checked license >>>>> >>>>> >>>>> - ran tests and test-coverage with Python 3.9.12 >>>>> >>>>> >>>>> +1 (non-binding) >>>>> >>>>> André Anastácio >>>>> >>>>> On Tuesday, August 13th, 2024 at 10:19 PM, Sung Yun < >>>>> sungwy...@gmail.com> wrote: >>>>> >>>>> Hi Everyone, >>>>> >>>>> I propose that we release the following RC as the official PyIceberg >>>>> 0.7.1 release. >>>>> >>>>> A summary of the high level features: >>>>> >>>>> * Fix `delete` to trace existing manifests when a data file is >>>>> partially rewritten >>>>> <https://github.com/apache/iceberg-python/pull/1046> >>>>> * Fix 'to_arrow_batch_reader' to respect the limit input arg >>>>> <https://github.com/apache/iceberg-python/pull/1042> >>>>> * Fix correctness of applying positional deletes on Merge-On-Read >>>>> tables <https://github.com/apache/iceberg-python/pull/1026> >>>>> * Fix overwrite when filtering data >>>>> <https://github.com/apache/iceberg-python/pull/1023> >>>>> * Bug fix for deletes across multiple partition specs on partition >>>>> evolution <https://github.com/apache/iceberg-python/pull/984> >>>>> * Fix evolving the table and writing in the same transaction >>>>> <https://github.com/apache/iceberg-python/pull/985> >>>>> * Fix scans when result is empty >>>>> <https://github.com/apache/iceberg-python/pull/997> >>>>> * Fix ListNamespace response in REST Catalog >>>>> <https://github.com/apache/iceberg-python/pull/995> >>>>> * Exclude Python 3.9.7 from list of supported versions >>>>> <https://github.com/apache/iceberg-python/pull/526> >>>>> * Allow setting write.parquet.row-group-limit >>>>> <https://github.com/apache/iceberg-python/pull/1016> >>>>> * Allow setting write.parquet.page-row-limit >>>>> <https://github.com/apache/iceberg-python/pull/1017> >>>>> <https://github.com/apache/iceberg-python/pull/1023> >>>>> * Fix pydantic warning during commit >>>>> <https://github.com/apache/iceberg-python/pull/972> >>>>> >>>>> The commit ID is f92994e85e526502a620506b964665b9afd385fe >>>>> >>>>> * This corresponds to the tag: pyiceberg-0.7.1rc2 >>>>> (d33192a3f64e1b5840c691b24a6071768a9fc79b) >>>>> * >>>>> https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.7.1rc2 >>>>> * >>>>> https://github.com/apache/iceberg-python/tree/f92994e85e526502a620506b964665b9afd385fe >>>>> >>>>> The release tarball, signature, and checksums are here: >>>>> >>>>> * https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.7.1rc2/ >>>>> >>>>> You can find the KEYS file here: >>>>> >>>>> * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>>> >>>>> Convenience binary artifacts are staged on pypi: >>>>> >>>>> https://pypi.org/project/pyiceberg/0.7.1rc2/ >>>>> >>>>> And can be installed using: pip3 install pyiceberg==0.7.1rc2 >>>>> >>>>> Instructions for verifying a release can be found here: >>>>> >>>>> * https://py.iceberg.apache.org/verify-release/ >>>>> >>>>> Please download, verify, and test. >>>>> >>>>> Please vote in the next 72 hours. >>>>> [ ] +1 Release this as PyIceberg 0.7.1 >>>>> [ ] +0 >>>>> [ ] -1 Do not release this because... >>>>> >>>>> >>>>>
