+1 (non-binding)
On Sat, Jan 25, 2025 at 10:13 AM Péter Váry <peter.vary.apa...@gmail.com> wrote: > +1 > Thanks for taking care of this! > > On Fri, Jan 24, 2025, 23:20 Yufei Gu <flyrain...@gmail.com> wrote: > >> Thanks for fixing this, Russell! >> >> +1 for keeping the changelog view related id as is, given the changelog >> view has been widely used. >> >> Yufei >> >> >> On Fri, Jan 24, 2025 at 12:35 PM Russell Spitzer < >> russell.spit...@gmail.com> wrote: >> >>> We added reserved fields into the Apache Iceberg repo to use with >>> ChangeLog views but these were never added to the spec. When >>> Row Lineage was added, those IDs inadvertently collided with the >>> ID's already set. >>> >>> In this PR <https://github.com/apache/iceberg/pull/12100/files> >>> >>> I add in the ChangeLog ID's and decrement the Row Lineage IDs so >>> that they no longer collide. >>> >>> >>> This is a minor oversight so I'm hoping we don't have any issues with >>> change. Please vote to acknowledge this change, or feel free to leave >>> a comment if you have a different fix or any questions. >>> >>
