-1 (binding) Since this version includes write support, I did some testing yesterday and found an issue with the V1 metadata <https://github.com/apache/iceberg-go/issues/344>. Someone that's working with Clickhouse ran into the same issue, and posted a PR <https://github.com/apache/iceberg-go/pull/347> just after that.
Next to the metadata, I did also some checks against the manifests and manifest-lists, and they all look good so far. I've been talking to Matt, and he's going to add some more integration tests to make the testing a bit easier. Sorry for the trouble here, but I want to make sure that we produce valid metadata to avoid compatibility issues down the line. Kind regards, Fokko Op wo 19 mrt 2025 om 22:00 schreef Jean-Baptiste Onofré <j...@nanthrax.net>: > +1 (non binding) > > I checked: > - hash and checksums are correct > - LICENSE and NOTICE are ok > - ASF header present (maybe we can add header in operation_string.go > even if it's a generated file) > - no binary found in the source distribution > - go test -v worked > - tested with CLI > > Thanks ! > > Regards > JB > > On Wed, Mar 19, 2025 at 4:54 PM Matt Topol <zotthewiz...@gmail.com> wrote: > > > > Hi, > > > > I would like to propose the following release candidate (RC0) of > > Apache Iceberg Go version v0.2.0. > > > > This release candidate is based on commit: > > 30705a69b6c64539c1b90852cd323088f429146c [1] > > > > The source release rc0 is hosted at [2]. > > > > Please download, verify checksums and signatures, run the unit tests, > > and vote on the release. See [3] for how to validate a release candidate. > > > > The vote will be open for at least 72 hours. > > > > [ ] +1 Release this as Apache Iceberg Go 0.2.0 > > [ ] +0 > > [ ] -1 Do not release this as Apache Iceberg Go 0.2.0 because... > > > > [1]: > https://github.com/apache/iceberg-go/tree/30705a69b6c64539c1b90852cd323088f429146c > > [2]: > https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-go-0.2.0-rc0 > > [3]: > https://github.com/apache/iceberg-go/blob/main/dev/release/README.md#verify >
