+1 (binding) checked license and unit/integration tests.
I've had a few failing tests related to ray. tests/integration/test_reads.py::test_ray_nan_rewritten[session_catalog_hive] FAILED tests/integration/test_reads.py::test_ray_nan_rewritten[session_catalog] FAILED tests/integration/test_reads.py::test_ray_all_types[session_catalog_hive] FAILED tests/integration/test_reads.py::test_ray_all_types[session_catalog] FAILED On Tue, Apr 29, 2025 at 12:47 PM Fokko Driesprong <fo...@apache.org> wrote: > +1 (binding) > > - Signature, checksum, licenses > - Ran some tests against example notebooks > <https://github.com/databricks/docker-spark-iceberg/pull/221>. > > Kind regards, > Fokko > > Op ma 28 apr 2025 om 17:59 schreef Kevin Liu <kevinjq...@apache.org>: > >> +1 non-binding >> >> I verified >> * signature, checksum, license >> * Ran unit and integration tests with python 3.12.9 on M1 >> >> Thanks for driving the release, Fokko! >> >> Best, >> Kevin Liu >> >> On Sun, Apr 27, 2025 at 7:04 PM Honah J. <hon...@apache.org> wrote: >> >>> +1 (binding) >>> >>> 1. Verified sigs/checksum/license >>> 2. Ran "make test-coverage" using python 3.10 >>> >>> Thanks Fokko for driving this release! >>> >>> Best, >>> Honah >>> >>> On Sat, Apr 26, 2025 at 9:43 PM Sung Yun <sungwy...@gmail.com> wrote: >>> >>>> Thank you Fokko for running this release! >>>> >>>> +1 (non-binding) >>>> >>>> I verified signatures, checksums, the LICENSE and NOTICE. >>>> >>>> Tested with python 3.11. >>>> >>>> Sung >>>> >>>> On Sat, Apr 26, 2025 at 10:51 AM Manu Zhang <owenzhang1...@gmail.com> >>>> wrote: >>>> >>>>> +1 (non-binding) >>>>> >>>>> Built and tested with python 3.10. >>>>> >>>>> Thanks, >>>>> Manu >>>>> >>>>> On Sat, Apr 26, 2025 at 12:02 PM Jean-Baptiste Onofré <j...@nanthrax.net> >>>>> wrote: >>>>> >>>>>> +1 (non binding) >>>>>> >>>>>> I checked: >>>>>> - LICENSE and NOTICE are good in the source distribution >>>>>> - ASF header present in all expected files >>>>>> - Hash and checksum are good >>>>>> - test and test-coverage work from source distribution >>>>>> >>>>>> Thanks ! >>>>>> Regards >>>>>> JB >>>>>> >>>>>> On Fri, Apr 25, 2025 at 5:05 PM Fokko Driesprong <fo...@apache.org> >>>>>> wrote: >>>>>> > >>>>>> > Hi Everyone, >>>>>> > >>>>>> > I propose releasing the following RC as the official PyIceberg >>>>>> 0.9.1 release. Thanks everyone for contributing! >>>>>> > >>>>>> > A list of patches that went into this release: >>>>>> > >>>>>> > https://github.com/apache/iceberg-python/milestone/11?closed=1 >>>>>> > >>>>>> > The commit ID is 7e1cfd18e3f8089eeae165a4092bf94305a812dc >>>>>> > >>>>>> > This corresponds to the tag: pyiceberg-0.9.1rc1 >>>>>> (93f65bf5cfb260c5390a4e17c54a77ca18837bf3) >>>>>> > >>>>>> https://github.com/apache/iceberg-python/releases/tag/pyiceberg-0.9.1rc1 >>>>>> > >>>>>> https://github.com/apache/iceberg-python/tree/7e1cfd18e3f8089eeae165a4092bf94305a812dc >>>>>> > >>>>>> > The release tarball, signature, and checksums are here: >>>>>> > >>>>>> > https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.9.1rc1/ >>>>>> > >>>>>> > You can find the KEYS file here: >>>>>> > >>>>>> > https://downloads.apache.org/iceberg/KEYS >>>>>> > >>>>>> > Convenience binary artifacts are staged on pypi: >>>>>> > >>>>>> > https://pypi.org/project/pyiceberg/0.9.1rc1/ >>>>>> > >>>>>> > And can be installed using: pip3 install pyiceberg==0.9.1rc1 >>>>>> > >>>>>> > Instructions for verifying a release can be found here: >>>>>> > >>>>>> > https://py.iceberg.apache.org/verify-release/ >>>>>> > >>>>>> > Please download, verify, and test. >>>>>> > >>>>>> > Please vote in the next 72 hours. >>>>>> > >>>>>> > [ ] +1 Release this as PyIceberg 0.9.1 >>>>>> > [ ] +0 >>>>>> > [ ] -1 Do not release this because... >>>>>> > >>>>>> > Kind regards, >>>>>> > Fokko >>>>>> >>>>>
