We might want to consider adding https://github.com/apache/iceberg/pull/14221 as well, since that fixes https://github.com/apache/iceberg/issues/14219.
On Tue, Sep 30, 2025 at 6:45 PM huaxin gao <[email protected]> wrote: > Thanks, Amogh and Péter, for adding these PRs to the 1.10.1 milestone. > I’ve also added https://github.com/apache/iceberg/pull/14186 and > https://github.com/apache/iceberg/pull/13804 to the milestone. > > On Tue, Sep 30, 2025 at 8:38 AM Péter Váry <[email protected]> > wrote: > >> Thanks Hoaxin for taking care of this! >> >> I have added a Flink PR (and the backport of it) to he milestone, >> which could cause correctness issues with the Flink Sink: >> >> - https://github.com/apache/iceberg/pull/14182 >> - https://github.com/apache/iceberg/pull/14213 >> >> Thanks aiborodin for reporting, and Max for providing a quick fix >> until we have a better solution! >> >> Amogh Jahagirdar <[email protected]> ezt írta (időpont: 2025. szept. 30., >> K, 2:09): >> >>> Thanks Huaxin for volunteering! I also went ahead and added >>> https://github.com/apache/iceberg/pull/14161 to the 1.10.1 milestone >>> which also looks to address the S3FileIO close issue mentioned earlier in >>> the thread. >>> >>> On Thu, Sep 25, 2025 at 1:15 PM huaxin gao <[email protected]> >>> wrote: >>> >>>> Thanks for kicking this off, Amogh, and thanks everyone for the fix >>>> pointers. >>>> >>>> I’m happy to volunteer as release manager for 1.10.1. I’ll track the >>>> candidates mentioned in this thread, monitor review progress, and verify >>>> backports. >>>> >>>> If there are other must-have fixes, please reply here so we can >>>> consider them for the patch. >>>> >>>> Thanks, >>>> >>>> Huaxin >>>> >>>> On Tue, Sep 23, 2025 at 12:53 PM Amogh Jahagirdar <[email protected]> >>>> wrote: >>>> >>>>> Thanks all! >>>>> >>>>> >Would it be possible to include >>>>> https://github.com/apache/iceberg/pull/14153 to enable variant >>>>> shredding >>>>> >>>>> Regarding this one, I don't think it should be in a patch release >>>>> since it's exposing an API on the data file writer and not really a fix. >>>>> Besides it is technically possible already to just use the lower level >>>>> parquet writer with the variant shredding spec and then produce a data >>>>> file >>>>> from that (it's a bit more clunky for sure which is why that API change in >>>>> the PR is helpful) but don't think it quite meets the criteria for being >>>>> in >>>>> a minor release. That criteria is primarily based on fixes. >>>>> >>>>> Thanks, >>>>> Amogh Jahagirdar >>>>> >>>>> >>>>> On Tue, Sep 23, 2025 at 10:13 AM Jean-Baptiste Onofré <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi Amogh >>>>>> >>>>>> Thanks for starting the discussion! >>>>>> >>>>>> I will create the PR to "relax" the LICENSE/NOTICE (to avoid the >>>>>> update pain before release). >>>>>> >>>>>> Regards >>>>>> JB >>>>>> >>>>>> On Mon, Sep 22, 2025 at 6:29 PM Amogh Jahagirdar <[email protected]> >>>>>> wrote: >>>>>> > >>>>>> > Hey folks, >>>>>> > >>>>>> > Iceberg 1.10 was released 2 weeks ago and there was one issue >>>>>> around incorrect variant filtering reported that I think meets the >>>>>> criteria >>>>>> for a patch release. The fix PR is in (thank you Drew). I wanted to kick >>>>>> this discussion thread off in case folks had other issues in the 1.10 >>>>>> release that they think warrant a patch release. >>>>>> > >>>>>> > I also think this PR is a good candidate for a patch release; this >>>>>> is for addressing a long-standing issue where closing the S3FileIO during >>>>>> an event like moving broadcast variables from memory to disk leads to an >>>>>> unexpected closing of the http client. There's still some discussion on >>>>>> the >>>>>> approach of the fix but there's general recognition that it's a >>>>>> legitimate >>>>>> issue, so I think it'd be ideal to get this in for a patch release as >>>>>> well. >>>>>> > >>>>>> > I've also created a milestone here. >>>>>> > >>>>>> > Thanks, >>>>>> > >>>>>> > Amogh Jahagirdar >>>>>> >>>>>
