Here's a fix for the underlying issue. This should unblock RC and also align with the artifact structure of other subprojects. PTAL! https://github.com/apache/iceberg-go/pull/588
Best, Kevin Liu On Wed, Oct 1, 2025 at 1:07 AM Fokko Driesprong <[email protected]> wrote: > +1 (binding) > > I ran into the same issue as Kevin, and the patch he suggested fixed it. > > Kind regards, > Fokko > > Op di 30 sep 2025 om 05:26 schreef Gang Wu <[email protected]>: > >> I think so, otherwise the release tarball will carry the rc suffix after >> untar. >> >> On Tue, Sep 30, 2025 at 12:56 AM Kevin Liu <[email protected]> wrote: >> >>> Thanks Gang! I started a PR to address this issue, >>> https://github.com/apache/iceberg-go/pull/581 >>> >>> I also found that the artifacts in the apache release directory has this >>> problem too, >>> https://dist.apache.org/repos/dist/release/iceberg/apache-iceberg-go-0.3.0/ >>> The tar file is named `apache-iceberg-go-0.3.0-rc0.tar.gz` and the >>> folder name after untar is `apache-iceberg-go-0.3.0-rc0` >>> Is this something we'd want to address? >>> >>> Best, >>> Kevin Liu >>> >>> On Sun, Sep 28, 2025 at 7:36 PM Gang Wu <[email protected]> wrote: >>> >>>> I just did a quick check and it seems that the issue came from >>>> https://github.com/apache/iceberg-go/blob/38794865aea6c4d09cec6f9d9a96ca0991469af0/dev/release/release_rc.sh#L68 >>>> >>>> The `id` is set to "apache-iceberg-go-${version}-rc${rc}" so calling >>>> mkdir produces rc suffix as well: >>>> https://github.com/apache/iceberg-go/blob/38794865aea6c4d09cec6f9d9a96ca0991469af0/dev/release/release_rc.sh#L92 >>>> >>>> Perhaps these lines can be removed if the above has been fixed: >>>> https://github.com/apache/iceberg-go/blob/38794865aea6c4d09cec6f9d9a96ca0991469af0/dev/release/release_rc.sh#L116-L118 >>>> >>>> On Sat, Sep 27, 2025 at 2:15 AM Kevin Liu <[email protected]> >>>> wrote: >>>> >>>>> >>>>> -1 (non-binding) >>>>> >>>>> Thanks Matt for working on the release! Excited to see another version >>>>> of iceberg-go. >>>>> >>>>> I was able to verify checksum, signature, build and tests. However, I >>>>> noticed that the directory structure is incorrect and I had to modify the >>>>> `dev/release/verify_rc.sh` script locally. >>>>> >>>>> The main problem is with the tar file >>>>> (`apache-iceberg-go-0.4.0.tar.gz`), I would expect the folder to be named >>>>> `apache-iceberg-go-0.4.0` when unzipped, instead the folder is named >>>>> `apache-iceberg-go-0.4.0-rc0`. >>>>> The folder name is important here because when we officially release, >>>>> the `.tar.gz` file is moved as is to the apache release/ directory and >>>>> should be the final release artifact for that version. >>>>> >>>>> I'll take a look and find a possible fix for this. >>>>> >>>>> Best, >>>>> Kevin Liu >>>>> >>>>> On Wed, Sep 24, 2025 at 8:56 AM Matt Topol <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I would like to propose the following release candidate (RC0) of >>>>>> Apache Iceberg Go version v0.4.0. >>>>>> >>>>>> This release candidate is based on commit: >>>>>> 1daab1394715394f5c61876e833d40fcb8e23992 [1] >>>>>> >>>>>> The source release rc0 is hosted at [2]. >>>>>> >>>>>> Please download, verify checksums and signatures, run the unit tests, >>>>>> and vote on the release. See [3] for how to validate a release >>>>>> candidate. >>>>>> >>>>>> The vote will be open for at least 72 hours. >>>>>> >>>>>> [ ] +1 Release this as Apache Iceberg Go v0.4.0 >>>>>> [ ] +0 >>>>>> [ ] -1 Do not release this as Apache Iceberg Go v0.4.0 because... >>>>>> >>>>>> [1]: >>>>>> https://github.com/apache/iceberg-go/tree/1daab1394715394f5c61876e833d40fcb8e23992 >>>>>> [2]: >>>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-go-0.4.0-rc0 >>>>>> [3]: >>>>>> https://github.com/apache/iceberg-go/blob/main/dev/release/README.md#verify >>>>>> >>>>>
