Oops, I merged the PR above already and just saw this thread. I wanted to
prevent merge conflicts, esp for all the scala files.
Please do take a look at the original PR. I'm happy to help iterate on it
in a follow up PR.

Best,
Kevin Liu


On Tue, Dec 2, 2025 at 4:03 AM Eduard Tudenhöfner <[email protected]>
wrote:

> In case anyone would like to review the PR that introduces spotless for
> scala code, please do so as we're planning to merge
> https://github.com/apache/iceberg/pull/8023 within the next couple of
> days.
>
>
>
> On Fri, Jun 27, 2025 at 11:47 AM Eduard Tudenhöfner <
> [email protected]> wrote:
>
>> I've reviewed the changes and they LGTM. Since we can fully control the
>> max line length for the Scala code, I would probably update it from 100 to
>> 120 or 140 to get more stuff on a single line.
>>
>> What do people think about adjusting the max line length?
>>
>>
>>
>> On Tue, Jun 24, 2025 at 1:51 PM Liu Xianyang <[email protected]>
>> wrote:
>>
>>> Hi community,
>>>    We have talked about the topic of “Apply spotless for scala code” two
>>> years ago. And now the patch(https://github.com/apache/iceberg/pull/8023)
>>> has been reactivated. Please take a look if you are interested in this.
>>>
>>> Thanks,
>>> Xianyang
>>>
>>

Reply via email to