-1 (binding)

Hi Matt, thanks for driving this release. The signatures, checksums, build and 
tests all check out for me on macOS arm64.

My -1 is regarding issues related to the license and notice files.

Given that the terraform release includes binary distributions, I believe we 
need to include NOTICE and LICENSE files that adds the attribution and license 
text for the code/bits included in the binary. Per 
https://www.apache.org/legal/release-policy.html#distribute-other-artifacts, 
these artifacts "may be distributed only if they contain LICENSE and NOTICE 
files", and 
https://www.apache.org/legal/release-policy.html#licensing-documentation 
requires each package's LICENSE and NOTICE to "account for the package's exact 
content".

I've created a PR to address the gap based largely on how apache/spark 
organizes the files for their binary distribution:

https://github.com/apache/terraform-provider-iceberg/pull/73

I think the right step here would be to create the next RC with the corrected 
LICENSE and NOTICE files included in the zip package.

Sung

On 2026/07/15 17:19:30 Neelesh Salian wrote:
> +1 (non-binding)
> 
> Verified locally on macOS (Apple Silicon):
> 
> 
>    - SHA-512: matches
>    - GPG signature: Good
>    - Git tag v0.1.0-rc0 resolves (annotated) to commit
>    2fe813329790eacf0b698bd430a57459fbf00e89
>    - LICENSE / NOTICE / README.md present
>    - Source tarball matches the signed git tag tree
>    - No unexpected binary files in the source tarball
>    - Builds from source: go build ./...  and go test./... succeeded locally
>    - Ran locally with both terraform and opentofu CLI locally.
> 
> 
> Thanks, Matt
> 
> On Mon, Jul 13, 2026 at 1:56 PM Matt Topol <[email protected]> wrote:
> 
> > Hi,
> >
> > I would like to propose the following release candidate (RC0) of the
> > Apache Iceberg Terraform provider version v0.1.0.
> >
> > This release candidate is based on commit:
> > 2fe813329790eacf0b698bd430a57459fbf00e89 [1]
> >
> > The source release rc0 is hosted at [2].
> > Convenience binaries for the Terraform/OpenTofu registries are attached to
> > the
> > GitHub prerelease at [3].
> >
> > Please download, verify checksums and signatures, run the tests, and vote
> > on
> > the release. See [4] for how to validate a release candidate.
> >
> > The vote will be open for at least 72 hours.
> >
> > [ ] +1 Release this as Apache Iceberg Terraform provider v0.1.0
> > [ ] +0
> > [ ] -1 Do not release this as Apache Iceberg Terraform provider v0.1.0
> > because...
> >
> > -- Matt
> >
> > [1]:
> > https://github.com/apache/terraform-provider-iceberg/tree/2fe813329790eacf0b698bd430a57459fbf00e89
> > [2]:
> > https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-terraform-0.1.0-rc0
> > [3]:
> > https://github.com/apache/terraform-provider-iceberg/releases/tag/v0.1.0-rc0
> > [4]:
> > https://github.com/apache/terraform-provider-iceberg/blob/main/docs/releasing.md#verifying-a-release
> >
> 

Reply via email to