GitHub user haubur added a comment to the discussion: Updated PR template and contributing guidelines
I think this is more than reasonable. As a newbie, I very much like the high effort and positive vibes from all the (core) members. This should not be washed out by energy draining work. So these policies can also protect new joiners who want to make a serious effort. In addition to the things already mentioned in the PR it might be reasonable to make benchmark tests mandatory. It's usually asked for, but I think it can be valuable to enforce them. If one added proper unit tests, integration tests and ran iggy-bench against the contribution there is very high likelihood that the implementation is solid. GitHub link: https://github.com/apache/iggy/discussions/2602#discussioncomment-15585249 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
