Amir, before making a review I want to be sure that all Ignite test suites are green.
However, seems that the patch based way contribution is broken. When I open a test run info for any suite I see the following http://ci.ignite.apache.org/viewLog.html?buildId=75417 FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':patchapply'. > Process 'command '/usr/lib/jvm/java-7-oracle/bin/java'' finished with > non-zero exit value 1 Artem, do we still support the patch based contribution? Amir, until we’re resolving issue with the patches please follow the pull-request way. This way of contribution is a preferred one and works fine: https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request> Before you push your pull request please get to know our coding guidelines (identations, brackets usage, etc.). You have some issues in your code related to guidelines. You’ll see them when familiarize yourself with this doc: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines <https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines> Regards, Denis > On 13 нояб. 2015 г., at 15:32, Denis Magda <[email protected]> wrote: > > Amir, great thanks! > > If you don't mind I'll review your changes in a couple of days. > > > However, probably someone else will do this earlier:) > > -- > Denis > > > From: Amir Akhmedov <[email protected] <mailto:[email protected]>> > Date: Fri, Nov 13, 2015 at 11:28 AM > Subject: IGNITE-1227 patch available > To: [email protected] <mailto:[email protected]> > > > Hi Igniters, > > I submitted patch for IGNITE-1227 > <https://issues.apache.org/jira/browse/IGNITE-1227 > <https://issues.apache.org/jira/browse/IGNITE-1227>>, could review it > whenever it is possible. > > Thanks. > > -- > Sincerely Yours Amir Akhmedov > >
