Thanks a lot Alexey. Regards Saikat
On Mon, Jul 4, 2016 at 12:01 PM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Saikat, > > Thanks for the contribution. I will make some minor changes to your patch > and push it to master soon. > > 2016-06-26 9:57 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > > > Hi Alexey, Ilya > > > > As discussed I have made the changes in the PR[1]. Please review and let > me > > know any feedback. > > > > [1] https://github.com/apache/ignite/pull/815 > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > > > > > Regards > > Saikat > > > > On Mon, Jun 20, 2016 at 10:40 PM, Saikat Maitra <saikat.mai...@gmail.com > > > > wrote: > > > > > Sure Alexey, > > > > > > Thank you > > > Saikat > > > > > > On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < > > > alexey.goncha...@gmail.com> wrote: > > > > > >> Saikat, > > >> > > >> Please also correct the test to check new methods for PARTITIONED and > > >> REPLICATED cache - I see that you only test them for local cache and > > >> partition 0 (I added a comment to the ticket). > > >> > > >> 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > > >> > > >> > Thank you Ilya, I will review and update PR accordingly. > > >> > > > >> > Regards > > >> > Saikat > > >> > > > >> > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh < > ilant...@gridgain.com> > > >> > wrote: > > >> > > > >> > > Hi Saikat, > > >> > > > > >> > > I've added a comment to the jira ticket regarding implementation > of > > >> > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] > > >> peekModes) > > >> > > method. > > >> > > > > >> > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < > > >> saikat.mai...@gmail.com > > >> > > > > >> > > wrote: > > >> > > > > >> > > > Hi > > >> > > > > > >> > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] and > > >> wanted > > >> > to > > >> > > > discuss further on this issue. > > >> > > > > > >> > > > 1. I am running 2 nodes cluster and running in client mode > another > > >> node > > >> > > for > > >> > > > functional test. I added 20 keys and keys are distributed in 2 > > >> nodes as > > >> > > 11 > > >> > > > keys in node 1 and 9 keys in node 2. When I am printing > partition > > 1 > > >> > size > > >> > > > and partition 2 size I can get correct values but incase I > provide > > >> some > > >> > > > other partition like 5 I am observing that I am getting 11 as > > value. > > >> > > > > > >> > > > 2. I have added unit test testpartitionsize() similar to > > testSize() > > >> but > > >> > > > similar tests are failing for both the tests. Need further > > >> > investigation > > >> > > on > > >> > > > the same. > > >> > > > > > >> > > > > > >> > > > Regards > > >> > > > Saikat > > >> > > > > > >> > > > [1] https://github.com/apache/ignite/pull/815 > > >> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > -- > > >> > > Best regards, > > >> > > Ilya > > >> > > > > >> > > > >> > > > > > > > > >
