Good, Hope that someone from the community will provide his feedback in the nearest time.
Sam, Andrey G., looks like that you are the ones who can do the review of Patrick’s changes. — Denis > On Aug 12, 2016, at 1:45 PM, Patrick Peralta <patrick.pera...@workday.com> > wrote: > > Thanks - it is ready for review! > -Patrick > >> On Aug 12, 2016, at 1:29 PM, Denis Magda <dma...@gridgain.com >> <mailto:dma...@gridgain.com>> wrote: >> >> Hi Patrick, >> >> Please see my answers inline >> >>> On Aug 12, 2016, at 7:36 AM, Patrick Peralta <patrick.pera...@workday.com> >>> wrote: >>> >>> Hi List, >>> >>> Per the development process I created a JIRA issue [1], submitted a PR [2], >>> and triggered a TeamCity build [3]. The instructions on the process >>> indicate: >>> >>> Move a corresponding JIRA ticket to "Patch Available" state and let the >>> community know that you're ready for review. >>> >>> I didn’t see a “Patch Available” option but I did see a “Submit Patch” >>> option which I selected. >> >> Yes, this was correct action. I’ve improved that doc saying that a >> contributor has to click on “Submit Patch” button in order to move a ticket >> into “Patch Available” state. >> >>> Afterwards JIRA returned an error page with a red background: >>> >> >> >>> There was an unexpected error while loading the issue. >>> If you think this message is wrong, please contact your JIRA administrators. >>> >> This should have been a temporary JIRA related issue. This happens from time >> to time on my side when I try to leave a comment or change a ticket status. >> >>> That being said, the state of the issue is “Patch Available” so I think it >>> worked. Please let me know if I’m missing anything from the process. >> >> Let us know when you’re ready for the review. >> >> — >> Denis >> >>> >>> Thanks again! >>> -Patrick >>> >>> 1. >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_IGNITE-2D3678&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=IIDSfiye-Z0xEzuMTlHMV8XOMgTX6JT_FfiT6-1GWQA&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_IGNITE-2D3678&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=IIDSfiye-Z0xEzuMTlHMV8XOMgTX6JT_FfiT6-1GWQA&e=> >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_IGNITE-2D3678&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=IIDSfiye-Z0xEzuMTlHMV8XOMgTX6JT_FfiT6-1GWQA&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_IGNITE-2D3678&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=IIDSfiye-Z0xEzuMTlHMV8XOMgTX6JT_FfiT6-1GWQA&e=> >>> > >>> 2. >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_ignite_pull_952&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=FAuDLbb_7ylxpJ46ctWQt7gU6RY6-C3mDXTVeQ07J6w&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_ignite_pull_952&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=FAuDLbb_7ylxpJ46ctWQt7gU6RY6-C3mDXTVeQ07J6w&e=> >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_ignite_pull_952&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=FAuDLbb_7ylxpJ46ctWQt7gU6RY6-C3mDXTVeQ07J6w&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_ignite_pull_952&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=FAuDLbb_7ylxpJ46ctWQt7gU6RY6-C3mDXTVeQ07J6w&e=> >>> > >>> 3. >>> https://urldefense.proofpoint.com/v2/url?u=http-3A__149.202.210.143-3A8111_viewLog.html-3FbuildId-3D298168-26tab-3DbuildResultsDiv-26buildTypeId-3DIgniteTests-5FIgniteDataGridFailover&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=iD4cBDEKbprgAbNCbqrxEgtZFTO4W_v1LES_Iz1s_hc&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__149.202.210.143-3A8111_viewLog.html-3FbuildId-3D298168-26tab-3DbuildResultsDiv-26buildTypeId-3DIgniteTests-5FIgniteDataGridFailover&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=iD4cBDEKbprgAbNCbqrxEgtZFTO4W_v1LES_Iz1s_hc&e=> >>> >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__149.202.210.143-3A8111_viewLog.html-3FbuildId-3D298168-26tab-3DbuildResultsDiv-26buildTypeId-3DIgniteTests-5FIgniteDataGridFailover&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=iD4cBDEKbprgAbNCbqrxEgtZFTO4W_v1LES_Iz1s_hc&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__149.202.210.143-3A8111_viewLog.html-3FbuildId-3D298168-26tab-3DbuildResultsDiv-26buildTypeId-3DIgniteTests-5FIgniteDataGridFailover&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=jK0LbLse5nbdQTUK9DBTPpidfHnZvqHSYxsiqV3KN_k&s=iD4cBDEKbprgAbNCbqrxEgtZFTO4W_v1LES_Iz1s_hc&e=> >>> > >>> >>> >>> On Aug 9, 2016, at 7:32 PM, Denis Magda <dma...@gridgain.com >>> <mailto:dma...@gridgain.com> <mailto:dma...@gridgain.com >>> <mailto:dma...@gridgain.com>><mailto:dma...@gridgain.com >>> <mailto:dma...@gridgain.com> <mailto:dma...@gridgain.com >>> <mailto:dma...@gridgain.com>>>> wrote: >>> >>> Hi Patrick, >>> >>> Thanks for showing interest in making Apache Ignite better! I do believe >>> that the skills you have let you dive in and get to know Ignite much faster. >>> >>> I’ve added you to the contributors list in JIRA. So for now you can assign >>> a ticket you want to take over on yourself. >>> >>> We would like to start by expanding the test coverage to include test cases >>> that (force) kill JVMs and assert that the data in the grid is intact and >>> correct. >>> >>> Ignite already has bunch of such tests that are aggregated in suites named >>> IgniteCacheFailoverTestSuite{N}. >>> I would suggest investigating existed tests first and add additional ones >>> if needed. >>> >>> — >>> Denis >>> >>> On Aug 9, 2016, at 1:35 PM, Patrick Peralta <patrick.pera...@workday.com >>> <mailto:patrick.pera...@workday.com> <mailto:patrick.pera...@workday.com >>> <mailto:patrick.pera...@workday.com>><mailto:patrick.pera...@workday.com >>> <mailto:patrick.pera...@workday.com> <mailto:patrick.pera...@workday.com >>> <mailto:patrick.pera...@workday.com>>>> wrote: >>> >>> Hello list! >>> >>> I am Patrick Peralta, a developer at Workday. We are in the process of >>> adopting Ignite and we are interested in joining the community and offering >>> contributions to the project! >>> >>> We would like to start by expanding the test coverage to include test cases >>> that (force) kill JVMs and assert that the data in the grid is intact and >>> correct. >>> >>> A little about me: I have previously worked on Oracle Coherence, Spring XD, >>> and various Spring Cloud Projects. I’ve also worked with Pivotal GemFire >>> and Apache ZooKeeper. >>> >>> According to the contribution >>> guidelines<https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_IGNITE_How-2Bto-2BContribute&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=GytxKT79Tts3Hbtw5OJxGWmqLg91ELFQICaUkuiB7eE&s=k0p4Fqa1YcyBzwLOhDxOo8_krG6Kh6WNi3Bm88LMBZA&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_IGNITE_How-2Bto-2BContribute&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=GytxKT79Tts3Hbtw5OJxGWmqLg91ELFQICaUkuiB7eE&s=k0p4Fqa1YcyBzwLOhDxOo8_krG6Kh6WNi3Bm88LMBZA&e=> >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_IGNITE_How-2Bto-2BContribute&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=GytxKT79Tts3Hbtw5OJxGWmqLg91ELFQICaUkuiB7eE&s=k0p4Fqa1YcyBzwLOhDxOo8_krG6Kh6WNi3Bm88LMBZA&e= >>> >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_IGNITE_How-2Bto-2BContribute&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=GytxKT79Tts3Hbtw5OJxGWmqLg91ELFQICaUkuiB7eE&s=k0p4Fqa1YcyBzwLOhDxOo8_krG6Kh6WNi3Bm88LMBZA&e=>> >>> > I should ask this list for contributor access to JIRA - my username is >>> pperalta. >>> >>> Thanks! >>> Patrick >>> >>> >>> >>> >>> >>> >>> Patrick Peralta >>> Senior Server Engineer >>> Workday, Inc. >>> 617-852-8388 (mobile) >>> patrick.pera...@workday.com <mailto:patrick.pera...@workday.com> >>> <mailto:patrick.pera...@workday.com >>> <mailto:patrick.pera...@workday.com>><mailto:patrick.pera...@workday.com >>> <mailto:patrick.pera...@workday.com><mailto:patrick.pera...@workday.com >>> <mailto:patrick.pera...@workday.com>>> >> > > Patrick Peralta > Senior Server Engineer > Workday, Inc. > 617-852-8388 (mobile) > patrick.pera...@workday.com <mailto:patrick.pera...@workday.com>
