Done. My PR: https://github.com/apache/ignite/pull/1466/files <https://github.com/apache/ignite/pull/1466>
2017-01-25 13:11 GMT+03:00 Александр Меньшиков <sharple...@gmail.com>: > Okay, I created issue: > https://issues.apache.org/jira/browse/IGNITE-4612 > > > 2017-01-24 18:19 GMT+03:00 Alexey Kuznetsov <akuznet...@apache.org>: > >> I think it is better to have such issue in JIRA "Minor code cleanup": >> >> 1) Cleanup unused imports. >> 2) Rename e -> ignored >> 3) Remove unused variables >> 4)... >> 5) PROFIT :) >> >> On Tue, Jan 24, 2017 at 9:46 PM, Александр Меньшиков < >> sharple...@gmail.com> >> wrote: >> >> > Hello, everyone! >> > >> > I found some unused variables in code. For example: >> > >> > Unnecessary argument in method >> > MiniFuture#onResult(ClusterTopologyCheckedException e) in inner class >> of >> > GridDhtLockFuture. >> > >> > There isn't another onResult() method (in super class including) with >> > another behavior. So argument can be safe delete. >> > >> > Also I found some ignored exceptions wasn't named "ignored". For example >> > unused exception was named "e0" in method: >> > >> > GridDhtTransactionalCacheAdapter#onForceKeysError(UUID, >> > GridDhtLockRequest, >> > IgniteCheckedException) >> > >> > >> > So I think i can go through code and cleanup thing like that. >> > >> > Need I create new issue in JIRA for cleanup or some issue for cleanup >> > already exists? If that please give me a link. >> > >> >> >> >> -- >> Alexey Kuznetsov >> > >
