Alexander, could you wipe out this test then making the code clean? — Denis
> On Feb 12, 2017, at 11:24 PM, Semyon Boikov <sboi...@gridgain.com> wrote: > > Hi, > > GridCacheOffHeapTest is some very old class and I think it can be removed. > Currently all actual benchmarks are in 'benchmarks' and 'yardstick' modules. > > Thanks > > On Sat, Feb 11, 2017 at 3:18 AM, Denis Magda <dma...@apache.org> wrote: > >> Yakov, Sam? >> >> Please join and share your thoughts. >> >> — >> Denis >> >>> On Feb 10, 2017, at 7:08 AM, Александр Меньшиков <sharple...@gmail.com> >> wrote: >>> >>> Denis, thank you for information. I see JMH in pom file in benchmarks >>> module. So this must be removed or it's okay for micro-benchmarks? >>> >>> 2017-02-10 0:04 GMT+03:00 Denis Magda <dma...@apache.org>: >>> >>>> Alexander, >>>> >>>> We use Yardstick benchmarks for performance measurements of Ignite: >>>> https://github.com/apacheignite/yardstick-ignite <https://github.com/ >>>> apacheignite/yardstick-ignite> >>>> >>>> In 1.9 it will be much easier to execute the benchmarks directly from >>>> Apache Ignite bundle: >>>> http://apache-ignite-developers.2346864.n4.nabble. >> com/IGNITE-4212-Ignite- >>>> Benchmarking-Simplification-and-Automation-td13079.html < >>>> http://apache-ignite-developers.2346864.n4.nabble. >> com/IGNITE-4212-Ignite- >>>> Benchmarking-Simplification-and-Automation-td13079.html> >>>> >>>> As for GridCacheOffHeapTest it looks like a candidate for removal. >> *Yakov, >>>> Sam*, do we still need this test? >>>> >>>>> On Feb 9, 2017, at 6:25 AM, Александр Меньшиков <sharple...@gmail.com> >>>> wrote: >>>>> >>>>> Hello, everyone. >>>>> >>>>> GridCacheOffHeapTest is about the Off-heap benchmarks. >>>>> >>>>> As I understand it right now we haven't clear vision how better make >>>>> benchmarks in Ignite. >>>>> >>>>> If it's not true, please make me know. >>>>> >>>>> I think it's a good idea to make benchmarks with JMH framework. It can >> be >>>>> load with maven, right now it's part of OpenJDK project. But it will be >>>>> included in Java 9 like standart framework for benchmarks. >>>>> >>>>> So what do you think, Igniters? >>>> >>>> >> >>
