+1 to Alexander’s proposal. Alexander, could you wrap the discussion up creating a ticket with detailed explanation what to do?
— Denis > On Feb 27, 2017, at 9:01 AM, Dmitriy Setrakyan <[email protected]> wrote: > > I like the idea of fixing the exception inheritance. > > On Mon, Feb 27, 2017 at 1:40 AM, Alexandr Kuramshin <[email protected] > <mailto:[email protected]>> wrote: > I think annotating the methods with @IgniteTransactional is redundant, > because they are already marked by "throws > TransactionTimeoutException/TransactionRollbackException/TransactionHeuristicException". > > For example, the same approach was used in JavaBeans 1.01 specs [1] with > TooManyListenersException. > > The only thing I'd like to do: make all > TransactionTimeoutException/TransactionRollbackException/TransactionHeuristicException > are derived from the same parent TransactionException. And declare all > transactional methods as "throws TransactionException" with consequent > Javadoc update. > > [1] > http://download.oracle.com/otndocs/jcp/7224-javabeans-1.01-fr-spec-oth-JSpec/ > <http://download.oracle.com/otndocs/jcp/7224-javabeans-1.01-fr-spec-oth-JSpec/> > > 2017-02-18 1:07 GMT+07:00 Dmitriy Setrakyan <[email protected] > <mailto:[email protected]>>: > On Fri, Feb 17, 2017 at 3:35 AM, Andrey Gura <[email protected] > <mailto:[email protected]>> wrote: > > > From my point of view @IgniteTransactional annotation is redundant > > entity which will just confuse and lead to questions like "How to use > > this annotation?" I think documention update is better way. > > > > Why do you think it will be confusing? This annotation is suggested purely > for documentation purposes, nothing else. Instead of adding documentation > to every method, we just add the annotation. User can check the > @IgniteTransactional javadoc to understand what this annotation means. > > > > -- > Thanks, > Alexandr Kuramshin >
