Thanks Vadim, I'll try to do review today. Semyon
On Mon, Apr 10, 2017 at 8:15 PM, Вадим Опольский <[email protected]> wrote: > Hello guys! > > Semyon, review please again. Test check corresponding IgniteCaches contain > expected number of entries. Test fails for HibernateNonStrictAccessStrategy. > > And per-cache thread local in method threadLocalForCache fix this issue. > > https://github.com/apache/ignite/pull/1768/files > > Vadim Opolski > > > 2017-04-07 14:15 GMT+03:00 Semyon Boikov <[email protected]>: > >> Hi Vadim, >> >> Test does not look correct to me. I think test need check that >> corresponding IgniteCaches contain expected number of entries like >> 'testCacheUsage' does. >> >> Thanks >> >> On Wed, Apr 5, 2017 at 3:26 PM, Вадим Опольский <[email protected]> >> wrote: >> >>> Hello everybody! >>> >>> Added test. Test fails after session.update(e2forUpdate). This update >>> must put into ENTITY2_NAME region, but it puts into ENTITY1_NAME and >>> ENTITY2_NAME regions. >>> >>> https://github.com/vadopolski/ignite/pull/1 >>> >>> Is it true? >>> >>> I have no idea how to change the method threadLocalForCache to support >>> NONSTRICT_READ_WRITE strategy. I tried to change it in accordance with >>> Cameroon Braid report. >>> >>> Vadim Opolski >>> >>> >>> ---------- Forwarded message ---------- >>> From: Вадим Опольский <[email protected]> >>> Date: 2017-04-03 17:39 GMT+03:00 >>> Subject: Re: IGNITE - 4760 : working in hibernate module >>> To: [email protected] >>> Cc: Valentin Kulichenko <[email protected]>, Semyon Boikov < >>> [email protected]> >>> >>> >>> Hello everyone! >>> >>> I added some change to method threadLocalForCache and added test >>> testEntityCacheNonStrictFails. >>> >>> How to reproduce situation when updates can be recorded to another >>> region? >>> >>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5 >>> 07ed73872d62b2969a7411/modules/hibernate/src/main/java/org/a >>> pache/ignite/cache/hibernate/HibernateRegionFactory.java >>> >>> https://github.com/vadopolski/ignite/blob/5aa25f3830fef14ac5 >>> 07ed73872d62b2969a7411/modules/hibernate/src/test/java/org/a >>> pache/ignite/cache/hibernate/HibernateL2CacheConfigurationSelfTest.java >>> >>> PullRequest >>> https://github.com/vadopolski/ignite/pull/4/files >>> >>> Vadim >>> >>> >>> >>> 2017-03-27 18:20 GMT+03:00 Denis Magda <[email protected]>: >>> >>>> Vadim, >>>> >>>> What IDE do you use? My recommendation would be to set up everything >>>> let’s say under IntellijIDEA or Eclipse and after that trying to compile >>>> from a terminal. >>>> >>>> This is how you can easily prepare the dev env in IntellijIDEA: >>>> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup < >>>> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup> >>>> >>>> — >>>> Denis >>>> >>>> > On Mar 27, 2017, at 7:14 AM, Вадим Опольский <[email protected]> >>>> wrote: >>>> > >>>> > Valentin, OK. >>>> > >>>> > To enabled it in my environment I done next: >>>> > - built project with command - mvn clean package -DskipTests >>>> -Prelease,lgpl >>>> > - added folder hibernate to modules in project structure >>>> > - added library to dependencies (without it import doesn't working) >>>> > >>>> > After that I have a lot of error, for instance: >>>> > - Class 'AccessStrategy' must either be declared abstract or >>>> implement abstract method 'remove(SharedSessionContractImplementor, >>>> Object) in 'RegionAccessStrategy' >>>> > >>>> > generateCacheKey >>>> > getCacheKeyId >>>> > getRegion >>>> > insert >>>> > afterInsert >>>> > update >>>> > afterUpdate >>>> > insert >>>> > afterInsert >>>> > update >>>> > get >>>> > putFromLoad >>>> > lockItem >>>> > unlockItem >>>> > remove >>>> > >>>> > Do anybody know the easier way to resolve this issue? >>>> > >>>> > Also tried to reimport all maven projects and cleansed repository in >>>> .m2. >>>> > Vadim Opolski >>>> > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> > 2017-03-25 2:42 GMT+03:00 Valentin Kulichenko < >>>> [email protected] <mailto:[email protected]>>: >>>> > Vadim, >>>> > >>>> > ignite-hibernate module is a part of 'lgpl' profile. Apparently it's >>>> not >>>> > enabled in your environment. >>>> > >>>> > -Val >>>> > >>>> > On Fri, Mar 24, 2017 at 4:38 PM, Вадим Опольский < >>>> [email protected] <mailto:[email protected]>> >>>> > wrote: >>>> > >>>> > > Hello everybody, >>>> > > >>>> > > I want to resolve issue №4760 >>>> > > https://issues.apache.org/jira/browse/IGNITE-4760 < >>>> https://issues.apache.org/jira/browse/IGNITE-4760> >>>> > > >>>> > > To find solution I'm going to change method threadLocalForCache and >>>> to add >>>> > > Junit test. >>>> > > >>>> > > Why folder hibernate is not a module ? Can I added it ? >>>> > > >>>> > > Vadim Opolski >>>> > > >>>> > >>>> >>>> >>> >>> >> >
