Rishi, I don't think listening to event and OOME can be related to each other. Please investigate what is consuming memory.
-Val On Wed, Apr 12, 2017 at 6:20 PM, Rishi Yagnik <rishiyag...@gmail.com> wrote: > Hi Val, > > Just want to share my experience here - > > with the code changes I suggested we run into issue,out of memory on ignite > with ignite thread whenever ignite cluster looses the client connection ( > we had a cluster with multicast communication) . > > > However, we changed our cluster with ip based configuration few days back > and hoping that solves our issues. > > Do you still think that listening events on spring cache manager is a good > design here ? > > will await for your feedback.. > > Thanks, > > On Fri, Mar 31, 2017 at 11:51 PM, Valentin Kulichenko < > valentin.kuliche...@gmail.com> wrote: > > > Hi Rishi, > > > > I looked at your changes and added a comment in the ticket. > > > > -Val > > > > On Wed, Mar 29, 2017 at 10:04 AM, Valentin Kulichenko < > > valentin.kuliche...@gmail.com> wrote: > > > > > Hi Rishi, > > > > > > I will review in next couple of days. > > > > > > -Val > > > > > > On Tue, Mar 28, 2017 at 8:24 PM, Rishi Yagnik <rishiyag...@gmail.com> > > > wrote: > > > > > >> Hi Val, > > >> > > >> Committed changes on IGNITE-2786, would like you to review the > > >> changes.Would you please review it ? > > >> > > >> Thanks, > > >> > > >> On Mon, Mar 27, 2017 at 6:11 PM, Valentin Kulichenko < > > >> valentin.kuliche...@gmail.com> wrote: > > >> > > >> > Rishi, > > >> > > > >> > You should be able to assign to tickets to yourself now. > > >> > > > >> > -Val > > >> > > > >> > On Mon, Mar 27, 2017 at 1:23 PM, Rishi Yagnik < > rishiyag...@gmail.com> > > >> > wrote: > > >> > > > >> > > Hi Val, > > >> > > > > >> > > My user name is ryagnik > > >> > > > > >> > > Thanks, > > >> > > Rishi > > >> > > > > >> > > On Mon, Mar 27, 2017 at 12:14 PM, Valentin Kulichenko < > > >> > > valentin.kuliche...@gmail.com> wrote: > > >> > > > > >> > > > Hi Rishi, > > >> > > > > > >> > > > What is your username in Jira? I will add you as a contributor. > > >> > > > > > >> > > > Also please go through [1] and [2] for all the details about our > > >> > process. > > >> > > > > > >> > > > [1] https://ignite.apache.org/community/contribute.html# > > contribute > > >> > > > [2] https://cwiki.apache.org/confluence/display/IGNITE/ > > >> > > Development+Process > > >> > > > > > >> > > > -Val > > >> > > > > > >> > > > On Sun, Mar 26, 2017 at 5:56 PM, Rishi Yagnik < > > >> rishiyag...@gmail.com> > > >> > > > wrote: > > >> > > > > > >> > > > > Hi Val, > > >> > > > > > > >> > > > > I started working on it but could not assign issue to me, how > > do I > > >> > > assign > > >> > > > > ticket to my self ? > > >> > > > > > > >> > > > > Do I need contributor access to contribute the fix ? > > >> > > > > > > >> > > > > Please clarify.. > > >> > > > > > > >> > > > > Thanks, > > >> > > > > > > >> > > > > On Fri, Mar 24, 2017 at 12:10 AM, Rishi Yagnik < > > >> > rishiyag...@gmail.com> > > >> > > > > wrote: > > >> > > > > > > >> > > > > > Hi Val, > > >> > > > > > > > >> > > > > > Sorry for the delay, I will work on the fix on weekend. > > >> > > > > > > > >> > > > > > Thanks, > > >> > > > > > > > >> > > > > > > > >> > > > > > On Mon, Mar 13, 2017 at 12:08 PM, Rishi Yagnik < > > >> > > rishiyag...@gmail.com> > > >> > > > > > wrote: > > >> > > > > > > > >> > > > > >> Hi Val, > > >> > > > > >> > > >> > > > > >> I will work on it in my spare time.. > > >> > > > > >> > > >> > > > > >> Take Care, > > >> > > > > >> Rishi > > >> > > > > >> > > >> > > > > >> > On Mar 13, 2017, at 10:54 AM, Valentin Kulichenko < > > >> > > > > >> valentin.kuliche...@gmail.com> wrote: > > >> > > > > >> > > > >> > > > > >> > Hi Rishi, > > >> > > > > >> > > > >> > > > > >> > Can you please assign the ticket to yourself and create a > > >> pull > > >> > > > request > > >> > > > > >> as > > >> > > > > >> > described in [1]? > > >> > > > > >> > > > >> > > > > >> > Let's follow the process :) > > >> > > > > >> > > > >> > > > > >> > [1] https://cwiki.apache.org/confl > > >> uence/display/IGNITE/How+to+ > > >> > > > > >> Contribute > > >> > > > > >> > > > >> > > > > >> > -Val > > >> > > > > >> > > > >> > > > > >> > On Sun, Mar 12, 2017 at 2:04 AM, ignite_dev2017 < > > >> > > > > rishiyag...@gmail.com> > > >> > > > > >> > wrote: > > >> > > > > >> > > > >> > > > > >> >> Hi Val, > > >> > > > > >> >> > > >> > > > > >> >> The fix which we applied as follows with > > SpringCacheManager > > >> - > > >> > > > > >> >> > > >> > > > > >> >> 1) Design was to listen for ignite re connect event > > >> > > > > >> >> 2) And clear the cache on reconnect > > >> > > > > >> >> > > >> > > > > >> >> See the following code below and let us know if this is > > >> > helpful - > > >> > > > > >> >> > > >> > > > > >> >> In afterPropertiesSet - > > >> > > > > >> >> > > >> > > > > >> >> //Handles the reconnect event, on server crashes OR > > network > > >> > > > failure, > > >> > > > > >> client > > >> > > > > >> >> connects to server and > > >> > > > > >> >> // destroy the cache > > >> > > > > >> >> IgnitePredicate<DiscoveryEvent> lsnr = iEvt -> { > > >> > > > > >> >> LOGGER.info("Received discovery event > [iEvt=" + > > >> > > > > iEvt.name() > > >> > > > > >> + > > >> > > > > >> >> ", > > >> > > > > >> >> discovery=" + iEvt.shortDisplay() + ']'); > > >> > > > > >> >> > > >> > > > > >> >> caches.keySet().forEach(key -> { > > >> > > > > >> >> ignite.destroyCache(key); > > >> > > > > >> >> caches.remove(key); > > >> > > > > >> >> } ); > > >> > > > > >> >> > > >> > > > > >> >> > > >> > > > > >> >> > > >> > > > > >> >> Let me know if you see any side effects with the fix. > > >> > > > > >> >> > > >> > > > > >> >> Thanks, > > >> > > > > >> >> Rishi > > >> > > > > >> >> > > >> > > > > >> >> > > >> > > > > >> >> > > >> > > > > >> >> -- > > >> > > > > >> >> View this message in context: http://apache-ignite- > > >> > > > > >> >> developers.2346864.n4.nabble. > > com/IGNITE-2766-Spring-Cache- > > >> > > > > >> >> Manager-ReConnect-Issue-tp15362.html > > >> > > > > >> >> Sent from the Apache Ignite Developers mailing list > > archive > > >> at > > >> > > > > >> Nabble.com. > > >> > > > > >> >> > > >> > > > > >> > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > -- > > >> > > > > > Rishi Yagnik > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > -- > > >> > > > > Rishi Yagnik > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > -- > > >> > > Rishi Yagnik > > >> > > > > >> > > > >> > > >> > > >> > > >> -- > > >> Rishi Yagnik > > >> > > > > > > > > > > > > -- > Rishi Yagnik >
