Yakov, Sasha, Are you ready to merge all the changes and close the ticket? As far as I understand, we plan to freeze 2.0 branch the next week.
— Denis > On Apr 11, 2017, at 8:59 AM, Denis Magda <dma...@apache.org> wrote: > > Yasha, > > I’ve updated the javadoc for IgniteConfiguration.metricsUpdateFrequency and > merged the changes into your branch (see JIRA). The rest is fine for now. An > advance documentation on how the heartbeats are implemented can be done in > readme.io <http://readme.io/>. > > — > Denis > >> On Apr 11, 2017, at 1:07 AM, Yakov Zhdanov <yzhda...@apache.org> wrote: >> >> Messages renaming is never compatible =) >> >> Denis, did you try to update javadocs? >> >> --Yakov >> >> 2017-04-10 21:41 GMT+03:00 Denis Magda <dma...@apache.org>: >> >>> Yasha, >>> >>> Thanks, I’ve replied you in the ticket. >>> >>> In a nutshel, let’s try to merge current breaking changes to 2.0 and do >>> the rest of compatible refactoring in further releases. Are you agree with >>> this? >>> >>> — >>> Denis >>> >>>> On Apr 10, 2017, at 8:39 AM, Yakov Zhdanov <yzhda...@apache.org> wrote: >>>> >>>> Alex Belyak, please go ahead. Thank you for your help! There were some >>> work >>>> I did not expect to happen. >>>> >>>> >>>> --Yakov >>>> >>>> 2017-04-10 18:13 GMT+03:00 Sasha Belyak <rtsfo...@gmail.com>: >>>> >>>>> Yakov, I can do replacement "heartbeat" -> "metricsUpdate". Can I get >>>>> https://issues.apache.org/jira/browse/IGNITE-4799 ? >>>>> >>>>> 2017-04-10 14:50 GMT+03:00 Yakov Zhdanov <yzhda...@apache.org>: >>>>> >>>>>> Guys, I have finished with initial changes. There were a little bit >>> more >>>>>> work to do than I originally estimated. >>>>>> >>>>>> Denis, can you please reply in the ticket? I would like you to propose >>>>>> documentation changes. Can you help? >>>>>> >>>>>> There is also another question - we have a lot of "heartbeat" mentions >>> in >>>>>> TCP disco - missed heartbeats, client heartbeats, heartbeat message. >>>>>> Should >>>>>> we go ahead and refactor this as well e.g. to maxMissedMetricUpdates? >>>>>> >>>>>> Also there are some changes to platforms and webconsole required. Alex >>>>>> Kuznetsov and Pavel Tupitsyn can you take a look at respective parts? >>>>>> >>>>>> -- >>>>>> Yakov >>>>>> >>>>> >>>>> >>> >>> >
