On Tue, May 30, 2017 at 2:46 PM, Denis Magda <dma...@apache.org> wrote:
> I don’t have any extra metrics in mind for now. All I want to say that > presently the Store metrics interface aggregates WAL and checkpointing > metrics and in the future we might add additional Store related metrics > there (that has nothing to do with WAL). So, this is why IgniteWalMetrics > doesn’t sound like a generic interface. > I think it is getting more and more confusing. I, for instance, do not understand where memory metrics end and storage begins, neither I think it is important to separate memory policy related metrics from the WAL or Checkpoint related metrics. How about we put them all together and have clear method names? > > — > Denis > > > On May 30, 2017, at 2:39 PM, Dmitriy Setrakyan <dsetrak...@apache.org> > wrote: > > > > On Tue, May 30, 2017 at 1:22 PM, Denis Magda <dma...@apache.org> wrote: > > > >> I’m afraid that in the future we might need to add non WAL related > metrics > >> under this interface. This is why it might make sense to keep the name > >> generic. > >> > > > > Hm... I am not sure we are going to have any other components in addition > > to WAL and Store here. What do you have in mind? > >
