Vova, license-wise it is OK, but I do not like adding the dependency. Right now we have H2 doing parsing for us. Why would ANTLR be better? What happens when we potentially notice a performance issue or any other issue in ANTLR under load?
Can we try doing parsing ourselves instead of adding a dependency? D. On Fri, Sep 8, 2017 at 2:23 AM, Vladimir Ozerov <[email protected]> wrote: > Igniters, > > We are evaluating ANTLR [1] as a parser generator for our SQL engine [2]. > At first glance it looks very good, we already able to parse certain SQL > commands with it. If implemented, it would greatly improve usability of our > SQL engine. However, it goes under BSD license and require one small > runtime dependency "antlr-runtime" [3]. > > I need assistance form someone with greater experience with different > licences - is it fine to add this dependency to Ignite? Would it violate > ASF licensing rules? > > AFAIK other ASF projects use it, e.g. Hive [4]. > > Vladimir. > > [1] http://www.antlr.org/ > [2] https://issues.apache.org/jira/browse/IGNITE-6276 > [3] https://mvnrepository.com/artifact/org.antlr/antlr-runtime > [4] https://github.com/apache/hive/blob/master/ql/pom.xml#L165 >
