Personally, I would still add an ability to set cluster name via the system property because in some cases this may be convenient (starting multiple clusters with the same configuration from ignite.sh, embedded deployments when configuration change is not available).
--AG 2017-10-11 14:13 GMT+03:00 Alexey Kuznetsov <akuznet...@apache.org>: > Created issue: https://issues.apache.org/jira/browse/IGNITE-6597 > > On Wed, Oct 11, 2017 at 5:21 PM, Sasha Belyak <rtsfo...@gmail.com> wrote: > > > Cluster name - yes > > Limit cluster building by cluster name - yes > > env/system property - no, let's add cluster name to ignite configuration. > > > > 2017-10-11 17:08 GMT+07:00 Dmitry Pavlov <dpavlov....@gmail.com>: > > > > > I like this idea too. Some imdg have such feature and allow to limit > > > cluster building only within cluster name. > > > > > > ср, 11 окт. 2017 г. в 12:38, Alexey Kuznetsov <akuznet...@apache.org>: > > > > > > > Hi, > > > > > > > > I'd like to up this thread for discussion. > > > > > > > > It seems that cluster name could be very useful together with > multicast > > > > discovery - do not accept nodes with different cluster name. > > > > By default, let's set cluster name to "DEFAULT_CLUSTER". > > > > > > > > Thoughts? > > > > > > > > On Fri, Mar 17, 2017 at 12:30 AM, Dmitriy Setrakyan < > > > dsetrak...@apache.org > > > > > > > > > wrote: > > > > > > > > > I am not sure I like naming clusters from an agent. It just sounds > > > > counter > > > > > intuitive for me. How about adding an optional IGNITE_CLUSTER_NAME > > env > > > > > property together with optional -DCLUSTER_NAME system property and > > > > > reserved CLUSTER_NAME user attribute? > > > > > > > > > > If user fails to provide any of the above, then we automatically > > assign > > > > the > > > > > timestamp of the first node or some UUID as a cluster name. > > > > > > > > > > Thoughts? > > > > > > > > > > D. > > > > > > > > > > On Thu, Mar 16, 2017 at 5:01 AM, Valentin Kulichenko < > > > > > valentin.kuliche...@gmail.com> wrote: > > > > > > > > > > > Alexey, > > > > > > > > > > > > Cluster doesn't know about the console, but web agent does, > right? > > I > > > > > think > > > > > > it should be his responsibility to assign the name. I.e. when > > > starting > > > > > the > > > > > > agent next to a particular cluster, user has to specify the name. > > If > > > > the > > > > > > console already has the cluster with this name, agent should not > > > start > > > > > with > > > > > > an exception suggesting to provide another name. > > > > > > > > > > > > Will this work? > > > > > > > > > > > > -Val > > > > > > > > > > > > On Thu, Mar 16, 2017 at 12:07 PM, Alexey Kuznetsov < > > > > > akuznet...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > Dmitriy, Sergi and Val. > > > > > > > > > > > > > > Web Console will be connected to several clusters at once. > > > > > > > And clusters do not know about Web Console, because Web Console > > > > collect > > > > > > > info from cluster via our REST-HTTP module. > > > > > > > So, I can distinguish clusters only by collection of node IDs > and > > > > give > > > > > > them > > > > > > > names like: "Cluster1, Clsuter2,...." > > > > > > > But if cluster restarted Web Console will detect it as new > > cluster > > > > and > > > > > > give > > > > > > > next auto-generated name "ClusterN". > > > > > > > > > > > > > > So, I'm not insist on adding "ClusterName" to > > IgniteConfiguration, > > > > but > > > > > > > could you give me a way > > > > > > > some how "mark" clusters to detect them even after full > restart. > > > > > > > > > > > > > > May be setting some sort of environment variable (it will be > > added > > > to > > > > > > node > > > > > > > attributes)? > > > > > > > So, if user need "Multi-cluster" support he should set > different > > > > > > > CLUSTER_NAME environment variable for different clusters. > > > > > > > > > > > > > > Any other ideas are welcome. > > > > > > > > > > > > > > On Thu, Mar 16, 2017 at 5:57 PM, Valentin Kulichenko < > > > > > > > valentin.kuliche...@gmail.com> wrote: > > > > > > > > > > > > > > > Alexey, > > > > > > > > > > > > > > > > How does the workflow look like? How do you add a cluster to > > this > > > > > > > dropdown > > > > > > > > on the console? I think that assigning a name should be part > of > > > > this > > > > > > > > process and should happen on the console itself. > > > > > > > > > > > > > > > > Adding yet another "name" to configuration will only confuse > > > users > > > > > even > > > > > > > > more. > > > > > > > > > > > > > > > > -Val > > > > > > > > > > > > > > > > On Thu, Mar 16, 2017 at 9:59 AM, Sergi Vladykin < > > > > > > > sergi.vlady...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > I don't like to add anything like this into Ignite config. > It > > > is > > > > a > > > > > > > > problem > > > > > > > > > of Web console how to name or rename different clusters > for a > > > > user, > > > > > > but > > > > > > > > not > > > > > > > > > Ignite cluster itself. > > > > > > > > > > > > > > > > > > Sergi > > > > > > > > > > > > > > > > > > 2017-03-16 4:21 GMT+03:00 Dmitriy Setrakyan < > > > > dsetrak...@apache.org > > > > > >: > > > > > > > > > > > > > > > > > > > I am OK with having a cluster name, but I would like us > to > > > > > generate > > > > > > > one > > > > > > > > > > automatically, if users do not define one explicitly. How > > > about > > > > > > > > > > "cluster_timestamp"? > > > > > > > > > > > > > > > > > > > > On Wed, Mar 15, 2017 at 5:38 PM, Alexey Kuznetsov < > > > > > > > > akuznet...@apache.org > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Igniters, > > > > > > > > > > > > > > > > > > > > > > I'm planning to start working on multi cluster support > > for > > > > Web > > > > > > > > Console > > > > > > > > > > > in order to be able to execute SQL queries on different > > > > > clusters > > > > > > > just > > > > > > > > > by > > > > > > > > > > > selecting > > > > > > > > > > > target cluster from drop-down. > > > > > > > > > > > > > > > > > > > > > > But Ignite does not have any cluster wide name. > > > > > > > > > > > > > > > > > > > > > > So, how about to add to Ignite (may be 2.0) property > > > "Cluster > > > > > > Name" > > > > > > > > to > > > > > > > > > > > Ignite configuration? > > > > > > > > > > > > > > > > > > > > > > Or as alternative way it could use "Mandatory User > > Defined > > > > > > > > Attribute". > > > > > > > > > > > > > > > > > > > > > > Node should be rejected to join cluster with different > > > > "Cluster > > > > > > > Name" > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thoughts? > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > Alexey Kuznetsov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Alexey Kuznetsov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Alexey Kuznetsov > > > > > > > > > > > > > -- > Alexey Kuznetsov >
