Nikita,

I am afraid this is incorrect fix, since zero is valid hash for schema. We
control whether the schema is est through the flag
BinaryUtils.FLAG_HAS_SCHEMA. Please try using it instead.

On Fri, Oct 27, 2017 at 6:38 PM, Nikita Amelchev <nsamelc...@gmail.com>
wrote:

> Hello, Igniters!
>
> I’ve fixed the issue where SQL query with unused fields throws an exception
> [1].
>
> Description of the problem: We can build a binary object without fields in
> the binary object builder. If we don't add a field, SchemaId will be set to
> zero. When we try to read field value, marshaller will try to find this
> schema and throw an exception.
>
> It was fixed by introducing of a new check on schemaId and when it equals
> to zero then the field value will return null.
>
> Please, review the changes [2]. Tests look good [3].
>
> 1. https://issues.apache.org/jira/browse/IGNITE-6692
>
> 2. https://reviews.ignite.apache.org/ignite/review/IGNT-CR-381
>
> 3.
> https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests&tab=
> projectOverview&branch_Ignite20Tests=pull%2F2918%2Fhead
>
>
> --
> Best wishes,
> Amelchev Nikita
>

Reply via email to