Vladimir Ozerov, thank you for taking your time for the review, I have implemented read part symmetrical to the write-related part. Please, look at it again [1,2]. Tests passed OK [2].
1. https://issues.apache.org/jira/browse/IGNITE-6666 2. https://github.com/apache/ignite/pull/2878/files 3. https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests&tab=projectOverview&branch_Ignite20Tests=pull%2F2878%2Fhead 2017-10-30 10:51 GMT+03:00 Vladimir Ozerov <[email protected]>: > Hi Nikita, > > See my comments in the ticket. > > On Fri, Oct 20, 2017 at 11:54 AM, Nikita Amelchev <[email protected]> > wrote: > > > Hello, Igniters! > > > > I found that the BinaryObjectImpl.writeFieldByOrder method does not > > support > > the TIME type [1]. I wrote test and fixed it [2]. TC tests look good [3]. > > > > Please, review. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6666 > > [2] https://github.com/apache/ignite/pull/2878/files > > [3] > > https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests&tab= > > projectOverview&branch_Ignite20Tests=pull%2F2878%2Fhead > > > > > > > > -- > > Best wishes, > > Amelchev Nikita > > > -- Best wishes, Amelchev Nikita
