Guys, I doubt that we should include spring-3 module in Apache Ignite 2.4 because we will drop Java 7 support. Only Spring Framework 4.x supports Java 8 without any limitations.
Thoughts? On Tue, Jan 16, 2018 at 6:01 PM, Michael Cherkasov <michael.cherka...@gmail.com> wrote: > Hi all, > > as I can see there are no objections, also the fix was reviewed by Anton V > and Andrey G: > https://issues.apache.org/jira/browse/IGNITE-7050 > > Could one of committer please integrate the change? > > Thanks, > Mike > . > > 2018-01-12 18:06 GMT+03:00 Michael Cherkasov <michael.cherka...@gmail.com>: > >> Hi Val, >> >> >What are the features that depend on Spring 4? >> at least this one breaks compatibility for sure with spring3: >> https://github.com/gridgain/apache-ignite/commit/dde348607ed >> 266f87bf594cb2a221ec39d84cfdb >> >> Thanks, >> Mike. >> >> 2018-01-12 2:32 GMT+03:00 Valentin Kulichenko < >> valentin.kuliche...@gmail.com>: >> >>> Mike, >>> >>> What are the features that depend on Spring 4? >>> >>> -Val >>> >>> On Thu, Jan 11, 2018 at 12:42 PM, Michael Cherkasov < >>> michael.cherka...@gmail.com> wrote: >>> >>> > Hi all, >>> > >>> > I want to integrate the following change: >>> > https://github.com/apache/ignite/pull/3147/ >>> > >>> > It adds spring3 support. >>> > >>> > With Ignite versions older 2.1 you can to force maven to use sprint3 >>> > dependency and everything would work fine. >>> > With newer versions this doesn't work, because now Ignite uses spring4 >>> > specific features and spring3 and ignite 2.1+ don't work simultaneously >>> on >>> > one project. >>> > >>> > If you need ignite 2.1+ you have to update spring in your project to >>> > version 4 at least, however, it isn't always possible to do so. >>> > So I want to add a new module that has no spring4 specific features and >>> > itself depends on spring3, with this module you don't even need to force >>> > maven to use specific spring version, you just can import ignite-spring3 >>> > and that's it. >>> > >>> > This will allow updating ignite version in legacy apps easier and >>> increase >>> > ignite 2+ adaptation. >>> > >>> > Any thoughts? Objections? >>> > >>> > Thanks, >>> > Mike. >>> > >>> >> >>
