Documentation consists of a set of unrelated code snippets for various 
operations. Do not treat it as a complete application or sample (the protocol 
is huge). This is why it’s totally fine to use numerical constants in the doc 
and leave it as as responsibility of a developer to define and use customs 
constants such as TYPE_INT.

—
Denis
 

> On Jan 18, 2018, at 6:47 PM, Alexey Kuznetsov <akuznet...@apache.org> wrote:
> 
> Prachi, Denis,
> 
> 
> It is OK that we are using numbers in code samples instead of named constants?
> 
> For example:
>    writeByteLittleEndian(3, out);  // Integer type code
> 
> It could be smth. like this:
>    writeByteLittleEndian(TYPE_INT, out);  // Integer type code
> 
> Where TYPE_INT is declared at some place:
> ....
> public static final int TYPE_INT = 3;
> ....
> 
> Make sense?
> 
> 
> On Fri, Jan 19, 2018 at 4:47 AM, Prachi Garg <pg...@gridgain.com 
> <mailto:pg...@gridgain.com>> wrote:
> Igniters,
> 
> The document for Binary Client Protocol (awaiting 2.4 release) is ready on
> Apache Ignite readme.io <http://readme.io/>. This document explains:
> 
>    - How to connect to Ignite cluster
>    - Common message format (Request/Response header)
>    - Supported Data types and their format
>    - Request/Response format for each message type
> 
> Here are the links -
> 
> https://apacheignite.readme.io/docs/binary-client-protocol 
> <https://apacheignite.readme.io/docs/binary-client-protocol>
> 
> https://apacheignite.readme.io/docs/binary-client-protocol-key-value-operations
>  
> <https://apacheignite.readme.io/docs/binary-client-protocol-key-value-operations>
> 
> https://apacheignite.readme.io/docs/binary-client-protocol-sql-operations 
> <https://apacheignite.readme.io/docs/binary-client-protocol-sql-operations>
> 
> https://apacheignite.readme.io/docs/binary-client-protocol-binary-type-operations
>  
> <https://apacheignite.readme.io/docs/binary-client-protocol-binary-type-operations>
> 
> https://apacheignite.readme.io/docs/binary-client-protocol-cache-configuration-operations
>  
> <https://apacheignite.readme.io/docs/binary-client-protocol-cache-configuration-operations>
> 
> 
> Currently these pages are hidden and are accessible only with the link.
> They will be active after the release.
> 
> -Prachi
> 
> 
> 
> -- 
> Alexey Kuznetsov

Reply via email to