Hi Tim, thanks for the update! I left you a comment on Jira.
Best regards, Vladisav On Mon, Jan 22, 2018 at 6:17 PM, Tim Onyschak <tonysc...@gmail.com> wrote: > Hey Vladisav, > > I implemented your requests. Take a look, specifically, i created an > interface to encapsulate the NodeUpdates and let > the DataStructuresProcessor handle the execution by checking for one type > as opposed to multiple if checks. In this case it checks for > GridCacheNodeUpdate > instance and executes onNodeRemoved. Let me know what you think. > > Thanks, > Tim > > > > On Sat, Jan 20, 2018 at 8:10 AM, Vladisav Jelisavcic <vladis...@gmail.com> > wrote: > >> Hi Tim, >> >> I reviewed your contribution and left you some comments on the pr. >> Thanks! >> >> Vladisav >> >> On Wed, Jan 17, 2018 at 10:14 PM, Vladisav Jelisavcic < >> vladis...@gmail.com> wrote: >> >>> Hi Tim, >>> >>> thank you for the contribution! >>> I'll do the review soon and let you know. >>> >>> >>> >>> On Wed, Jan 17, 2018 at 8:56 AM, Yakov Zhdanov <yzhda...@apache.org> >>> wrote: >>> >>>> Thanks Tim! I hope Vlad can review your patch. If this does not happen >>>> in >>>> 2-3 days I will take a look. Can you please let me know on weekend if I >>>> need to? >>>> >>>> --Yakov >>>> >>>> 2018-01-16 23:36 GMT+03:00 Tim Onyschak <tonysc...@gmail.com>: >>>> >>>> > Hey all, >>>> > >>>> > I created a patch and posted to user group, was told feed back would >>>> be >>>> > left on the jira. I wanted to see if we could get a fix in with 2.4, >>>> could >>>> > somebody please review. >>>> > >>>> > http://apache-ignite-users.70518.x6.nabble.com/Semaphore- >>>> > Stuck-when-no-acquirers-to-assign-permit-td18639.html >>>> > >>>> > https://issues.apache.org/jira/browse/IGNITE-7090 >>>> > >>>> > https://github.com/apache/ignite/pull/3138 >>>> > >>>> > Thanks, >>>> > Tim >>>> > >>>> >>> >>> >> >
