Thank you. I am sure you now, by anyway: It is important to fail test in code, because all muted tests are actually started in suite each run. And if some test causes timeout it will cause it in both cases: muted and not muted.
чт, 22 февр. 2018 г. в 10:17, Nikolay Izhikov <nizhi...@apache.org>: > Hello, Dmitry. > > OK, I'll rerun TC with muted test. > > В Чт, 22/02/2018 в 07:12 +0000, Dmitry Pavlov пишет: > > Hi Nikolay, > > > > It seems Data structures test suite is still have timeout. Could you fail > > test caused this timeout? > > > https://ci.ignite.apache.org/viewLog.html?buildId=1105706&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_IgniteDataStructures > > > > Data structures is most relevant suite so I suggest to re-run it after > > failing problematic test. > > > > Most probably this test is > > > GridCachePartitionedDataStructuresFailoverSelfTest.testSemaphoreSingleNodeFailure. > > And it can be failed with link to > > https://issues.apache.org/jira/browse/IGNITE-5975 > > > > > > Sincerely, > > Dmitriy Pavlov > > > > чт, 22 февр. 2018 г. в 10:07, Nikolay Izhikov <nizhi...@apache.org>: > > > > > Andrey, > > > > > > I made TC run. > > > Please, see my comment in JIRA. > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-6005?focusedCommentId=16372502&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16372502 > > > > > > > > > В Ср, 21/02/2018 в 15:03 +0300, Andrey Gura пишет: > > > > Nikolay, > > > > > > > > it doesn't matter. I just want to be sure that there are no new > > > > failures in tests. > > > > > > > > On Wed, Feb 21, 2018 at 1:14 PM, Dmitry Pavlov < > dpavlov....@gmail.com> > > > > > > wrote: > > > > > Hi, I didn't find any runs in our new TC suite group (project) for > > > > > > 2.4+: > > > > > > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=pull%2F2773%2Fhead > > > > > > > > > > So, Nikolay, I suggest to start RunAll in this suite group. > > > > > > > > > > I can check results later in compare with master. > > > > > > > > > > ср, 21 февр. 2018 г. в 11:48, Nikolay Izhikov <nizhi...@apache.org > >: > > > > > > > > > > > Hello, Andrey. > > > > > > > > > > > > Do you run TC by yourself, or I as patch contributor should do > it? > > > > > > > > > > > > В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет: > > > > > > > I'll merge it if there are no any objections. But, the first, > I'll > > > > > > run > > > > > > > > > > > > TC once again. > > > > > > > > > > > > > > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" < > > > > > > > > > > > > dpavlov....@gmail.com> написал: > > > > > > > > Hi Igniters, > > > > > > > > > > > > > > > > It seems this issue review process hang up. > > > > > > > > > > > > > > > > Andrey Gura had concerns about this implementation. In the > same > > > > > > time > > > > > > > > > > > > Ilya L > > > > > > > > checked this implementation and approves it. > > > > > > > > > > > > > > > > I didn't find points to improve and concerns are not clear > for > > > > > > me. I > > > > > > > > > > > > didn't > > > > > > > > managed to get more info in issue > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-6005 comments. > > > > > > > > > > > > > > > > What can be our next step to solve this? > > > > > > > > > > > > > > > > Absence of this fix causes 100% timeout in Data Structures > suite > > > > > > and > > > > > > > > > > > > wastes > > > > > > > > agents for a long time. > > > > > > > > > > > > > > > > Sincerely, > > > > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > > > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh < > > > > > > ilant...@gridgain.com>: > > > > > > > > > > > > > > > > > Hi Nikolay, > > > > > > > > > > > > > > > > > > Thanks for contribution! > > > > > > > > > > > > > > > > > > I will try to review your pull request by tomorrow. > > > > > > > > > > > > > > > > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov < > > > > > > > > > > > > nizhi...@apache.org> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > > > > > > > I've fix some relatively small issue(100 loc) IGNITE-6005 > > > > > > [1], PR > > > > > > > > > > > > [2] > > > > > > > > > > The fix in DataStructuresProcessor.java > > > > > > > > > > > > > > > > > > > > As far as I can see from git log Ilya Lantukh maintains > this > > > > > > piece > > > > > > > > > > > > of > > > > > > > > > code. > > > > > > > > > > > > > > > > > > > > Ilya, can you please take a look at the fix? > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005 > > > > > > > > > > > > > > > > > > > > [2] https://github.com/apache/ignite/pull/2773 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Best regards, > > > > > > > > > Ilya > > > > > > > > >
