Hell, Denis. I've done review and merge yersteday.
master commit - https://github.com/apache/ignite/commit/fcc4d4a357413eb4856ca5c72d301738568060e2 2.5 commit - https://github.com/apache/ignite/commit/2679cc5a18eb00599c9f00b0f46dbcaa6352c0cb The task is in resolved state. В Пт, 27/04/2018 в 23:32 -0700, Denis Magda пишет: > Akmal, Nikolay, > > Do you have any progress on this? Let's finish with this ticket within 2.5 > scope and merge it there. > > -- > Denis > > On Thu, Apr 19, 2018 at 10:07 PM, Akmal Chaudhri < > akmal.chaud...@gridgain.com> wrote: > > > Nikolay, > > > > Ok. I _think_ it should be better now, so we can try again. > > > > 1. I removed the 3 pull requests. > > 2. I renamed the Java code files with a "Java" prefix. > > 3. I created a test file for the Java code, using the existing test file > > for the Scala code. > > 4. I updated the TestSuite with bullet #3 above. > > 5. I combined all changes into a single pull request. > > > > Note that one of the tests still fails locally due to the path issue. I > > have no idea how to fix this, although the code works fine. > > > > Thank you. > > > > > > > > On 19 April 2018 at 22:41, Nikolay Izhikov <nizhi...@apache.org> wrote: > > > > > Hello, Akmal. > > > > > > 1. As a first step. Let's combine all changes you want to merge into a > > > single pull request. > > > > > > I suggest that your changes relates only to "examples" module. > > > > > > 2. So, when you will have one pull request, please, run "Examples" test > > > suite on Team City for your branch. > > > After that, attach link to execution into issue. > > > > > > After completing step 1 I will be able to review your changes. > > > After completing step 2 and review we will be to merge your changes to > > > master. > > > > > > В Чт, 19/04/2018 в 15:30 +0100, Akmal Chaudhri пишет: > > > > Nikolay, > > > > > > > > The code is the same for the attached version to the ticket, as well as > > > > > > the > > > > pull version. The tests are also the same as those provided for the > > > > Scala > > > > DF examples. I have checked and they work correctly with the exception > > > > of > > > > the path issue which I previously mentioned on the dev list. > > > > > > > > I'm afraid I am new to this whole process, so need someone in the > > > > > > community > > > > to assist. > > > > > > > > To summarise, > > > > > > > > 1. The Java Spark DF code is equivalent in functionality to the Scala > > > > > > Spark > > > > DF code. These Java examples were requested by Denis Magda, since only > > > > Scala examples were previously available. > > > > 2. The tests scripts provided with the Scala DF code work just fine > > > > with > > > > the Java code. > > > > 3. There is a problem with a path issue in test #2, where the code > > > > reads > > > a > > > > JSON file. Since the Java code is equivalent to the Scala code, I don't > > > > know how the Scala code passed this test. > > > > > > > > > > > > > > > > On 18 April 2018 at 22:11, Nikolay Izhikov <nizhi...@apache.org> > > > > wrote: > > > > > > > > > Hello, Akmal. > > > > > > > > > > I see 3 pull requests attached to the ticket [1], [2], [3]. > > > > > I see 3 java files attached to the ticket, also. > > > > > > > > > > Which changes you want to be reviewed and merge? Please, clarify. > > > > > > > > > > Delete all unnecessary pull requests link from the ticket. > > > > > Add new examples to the tests so we can test it on the Team City. > > > > > You can take IgniteDataFrameSelfTest as an example. > > > > > > > > > > I also suggest to rename java examples with "Java" prefix. > > > > > > > > > > IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExampl > > > > > > e.java > > > > > > > > > > [1] https://github.com/apache/ignite/pull/3857 > > > > > [2] https://github.com/apache/ignite/pull/3858I > > > > > [3] https://github.com/apache/ignite/pull/3859 > > > > > [4] https://github.com/apache/ignite/blob/master/examples/ > > > > > src/test/spark/org/apache/ignite/spark/examples/ > > > > > IgniteDataFrameSelfTest.java > > > > > > > > > > > > > > > > > > > > > > > > > В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет: > > > > > > If any community members have time, please review the code. Three > > > > > > Java > > > > > > files are attached to the Jira ticket: > > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-7909 > > > > > > > > > > > > The code should be functionally equivalent to the Scala Data Frames > > > > > > code > > > > > > that was shipped in 2.4. > > > > > > > > > > > > Data Frame documentation is here: > > > > > > > > > > > > https://apacheignite-fs.readme.io/docs/ignite-data-frame > > > > > > > > > > > > Thank you!
signature.asc
Description: This is a digitally signed message part
