Andrey, I realized that we missed one very important thing - H2 version upgrade [1]. This is very important thing because new version contain optimization to IN clause processing. All we need is to upgrade H2 vesion from 1.4.196 to 1.4.197 and re-run tests. Can we target it to 2.5 release?
[1] https://issues.apache.org/jira/browse/IGNITE-4150 On Mon, May 7, 2018 at 6:07 PM, Andrey Gura <[email protected]> wrote: > Ivan, > > ok, targeted to 2.5. Thanks! > > On Mon, May 7, 2018 at 5:24 PM, Dmitry Pavlov <[email protected]> > wrote: > > Thank you, Andrey, > > > > I saw 1 more proposal in separate topic > > http://apache-ignite-developers.2346864.n4.nabble. > com/RE-Hi-can-we-squeeze-this-into-2-5-https-issues-apache- > org-jira-browse-IGNITE-8439-td30161.html > > > > and 1 proposal here related to ML: > > http://apache-ignite-developers.2346864.n4.nabble. > com/Apache-Ignite-2-5-release-td28927i20.html#a30155 > > but here Yuriy Babak probably should share his opinion. > > > > Sincerely, > > Dmitriy Pavlov > > > > пн, 7 мая 2018 г. в 17:09, Andrey Gura <[email protected]>: > >> > >> Sergey, Dmitry, > >> > >> I've targeted your issues to 2.5 release. > >> > >> Thanks! > >> > >> On Fri, May 4, 2018 at 5:51 PM, Dmitry Pavlov <[email protected]> > >> wrote: > >> > I did not understand process. > >> > > >> > Is it required to receive someone reply that issue is agreed to be > >> > included > >> > into release? > >> > > >> > Or because there is no response I can cherry-pick anything to 2.5 > hoping > >> > it > >> > is lazy consensus; no one objected. > >> > > >> > пт, 4 мая 2018 г. в 17:44, Denis Magda <[email protected]>: > >> > > >> >> Igniters, > >> >> > >> >> I got lost. Were all the bugs reported in this thread fixed and > merged > >> >> into > >> >> 2.5 branch? Is there any bug which fix is still in progress? > >> >> > >> >> Just want to know when the QA and bugs fixing stage is over. > >> >> > >> >> -- > >> >> Denis > >> >> > >> >> On Thu, May 3, 2018 at 9:14 AM, Dmitry Pavlov <[email protected] > > > >> >> wrote: > >> >> > >> >> > Hi Andrey, Igniters, > >> >> > > >> >> > I propose to include > >> >> > https://issues.apache.org/jira/browse/IGNITE-8347 > >> >> fix > >> >> > to 2.5. It is quite isolated. > >> >> > > >> >> > Memory leak can be reproduced if node in embedded mode is restarted > >> >> > under > >> >> > the same process (thread is alive and cleanup is not performed). > >> >> > > >> >> > Sincerely, > >> >> > Dmitriy Pavlov > >> >> > > >> >> > сб, 28 апр. 2018 г. в 19:49, Sergey Chugunov > >> >> > <[email protected] > >> >> >: > >> >> > > >> >> > > Igniters, > >> >> > > > >> >> > > I would like to include into release another critical bug found > in > >> >> > > ZooKeeper Discovery [1]. > >> >> > > > >> >> > > Situation reproducing the error is very specific and rare but it > >> >> > > leads > >> >> to > >> >> > > full cluster shut down. At the same time fix for it very simple > and > >> >> > > I > >> >> > don't > >> >> > > expect it is too risky. > >> >> > > > >> >> > > [1] https://issues.apache.org/jira/browse/IGNITE-8421 > >> >> > > > >> >> > > On Sat, Apr 28, 2018 at 6:08 PM Alexei Scherbakov < > >> >> > > [email protected]> wrote: > >> >> > > > >> >> > > > Guys, > >> >> > > > > >> >> > > > Consider including this [1] to release. > >> >> > > > > >> >> > > > It's major usability issue and if not fixed now will lead to > >> >> > > compatibility > >> >> > > > issues in subsequent release. > >> >> > > > > >> >> > > > [1] https://issues.apache.org/jira/browse/IGNITE-8418 > >> >> > > > > >> >> > > > пт, 27 апр. 2018 г. в 21:34, Andrey Gura <[email protected]>: > >> >> > > > > >> >> > > > > Of course I meant bug fixes, not bugs :) > >> >> > > > > > >> >> > > > > On Fri, Apr 27, 2018 at 9:28 PM, Andrey Gura < > [email protected]> > >> >> > wrote: > >> >> > > > > > Eduard, Pavel, > >> >> > > > > > > >> >> > > > > > mentioned bugs are good candidates for including to > release. > >> >> > > > > > > >> >> > > > > > Targeted to 2.5. > >> >> > > > > > > >> >> > > > > > Thanks! > >> >> > > > > > > >> >> > > > > > On Fri, Apr 27, 2018 at 5:06 PM, Pavel Kovalenko < > >> >> > [email protected] > >> >> > > > > >> >> > > > > wrote: > >> >> > > > > >> Igniters, > >> >> > > > > >> > >> >> > > > > >> I would like to add this issue > >> >> > > > > >> https://issues.apache.org/jira/browse/IGNITE-8405 to 2.5 > >> >> > > > > >> scope. > >> >> > > > > >> > >> >> > > > > >> > >> >> > > > > >> 2018-04-27 16:59 GMT+03:00 Eduard Shangareev < > >> >> > > > [email protected] > >> >> > > > > >: > >> >> > > > > >> > >> >> > > > > >>> Guys, > >> >> > > > > >>> I have finished > >> >> > > > > >>> ttps://issues.apache.org/jira/browse/IGNITE-7628. > >> >> > > > > >>> > >> >> > > > > >>> It looks like a good candidate to merge to 2.5. > >> >> > > > > >>> > >> >> > > > > >>> On Fri, Apr 27, 2018 at 1:32 PM, Ivan Rakov < > >> >> > [email protected] > >> >> > > > > >> >> > > > > wrote: > >> >> > > > > >>> > >> >> > > > > >>> > Dmitriy, > >> >> > > > > >>> > > >> >> > > > > >>> > There are some notes about WAL compaction in > "Persistence > >> >> Under > >> >> > > the > >> >> > > > > Hood" > >> >> > > > > >>> > article: > >> >> > > > https://cwiki.apache.org/confluence/display/IGNITE/Ignite+ > >> >> > > > > >>> > > >> >> > > > > >>> > Persistent+Store+-+under+the+ > hood#IgnitePersistentStore-und > >> >> > > > > >>> > erthehood-WALcompaction > >> >> > > > > >>> > Please take a look - it has all the answers. > >> >> > > > > >>> > > >> >> > > > > >>> > Best Regards, > >> >> > > > > >>> > Ivan Rakov > >> >> > > > > >>> > > >> >> > > > > >>> > > >> >> > > > > >>> > On 27.04.2018 2:28, Dmitriy Setrakyan wrote: > >> >> > > > > >>> > > >> >> > > > > >>> >> On Fri, Apr 27, 2018 at 6:38 AM, Ivan Rakov < > >> >> > > > [email protected]> > >> >> > > > > >>> >> wrote: > >> >> > > > > >>> >> > >> >> > > > > >>> >> Folks, > >> >> > > > > >>> >>> > >> >> > > > > >>> >>> I have a fix for a critical issue related to WAL > >> >> compaction: > >> >> > > > > >>> >>> https://issues.apache.org/jira/browse/IGNITE-8393 > >> >> > > > > >>> >>> In short, if part of WAL archive is broken, attempt > to > >> >> > compress > >> >> > > > it > >> >> > > > > may > >> >> > > > > >>> >>> result in spamming warnings in infinite loop. > >> >> > > > > >>> >>> I think it's also worth being included in 2.5 > release. > >> >> > > > > >>> >>> > >> >> > > > > >>> >>> Let's include it, especially given that the fix is > >> >> > > > > >>> >>> done. > >> >> > > > > >>> >> > >> >> > > > > >>> >> Ivan, on another note, is WAL compaction described > >> >> > > > > >>> >> anywhere? > >> >> > > What > >> >> > > > > do we > >> >> > > > > >>> do > >> >> > > > > >>> >> internally to compact WAL and by what factor are we > able > >> >> > > > > >>> >> to > >> >> > > reduce > >> >> > > > > the > >> >> > > > > >>> WAL > >> >> > > > > >>> >> file size? > >> >> > > > > >>> >> > >> >> > > > > >>> >> D. > >> >> > > > > >>> >> > >> >> > > > > >>> >> > >> >> > > > > >>> > > >> >> > > > > >>> > >> >> > > > > >>> > >> >> > > > > >>> -- > >> >> > > > > >>> Best regards, > >> >> > > > > >>> Eduard. > >> >> > > > > >>> > >> >> > > > > > >> >> > > > > >> >> > > > > >> >> > > > -- > >> >> > > > > >> >> > > > Best regards, > >> >> > > > Alexei Scherbakov > >> >> > > > > >> >> > > > >> >> > > >> >> >
