I'd like to thank GridGain's engineers for the plugin's donation. I believe that the plugin will help Ignite's developers prepare PR with the higher quality of code style what will reduce reviewer's time for PR checking.
Dmitry thank you for the task's pushing! On Mon, May 14, 2018 at 7:27 PM, Dmitry Pavlov <dpavlov....@gmail.com> wrote: > Anton, thank you for pointing to this. > > I've updated wiki page with build and references: > https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules > > and attached jar file > https://cwiki.apache.org/confluence/pages/viewpageattachments.action?pageId=57901460 > > Thanks to Vyacheslav plugin is now published. > > Sincerely, > Dmitriy Pavlov > > > пн, 14 мая 2018 г. в 19:14, Anton Vinogradov <a...@apache.org>: >> >> Jar already attached to issue :) >> >> see https://issues.apache.org/jira/browse/IGNITE-5698 >> >> пн, 14 мая 2018 г. в 19:05, Dmitry Pavlov <dpavlov....@gmail.com>: >> >> > Hi Folks, >> > >> > I suggest to keep it in https://github.com/dspavlov/ignite-abbrev-plugin >> > for >> > the beginning. Late we can consider Apache repo. >> > >> > But for wiki I need some distribution to attach first. >> > >> > Vyacheslav, could you remind me if we already have one? >> > >> > пн, 14 мая 2018 г. в 19:00, Anton Vinogradov <a...@apache.org>: >> > >> > > Awesome! >> > > >> > > Let's mention it officially on wiki. >> > > Do we need special apache repo for this plugin? As for me, public >> > > github >> > > repo is enough. >> > > >> > > пн, 14 мая 2018 г. в 18:34, Dmitriy Pavlov <dpav...@gridgain.com>: >> > > >> > > > Hi Igniters, Vyacheslav, >> > > > >> > > > I had discussion about this plugin. As GridGain representative I >> > approve >> > > > change of file headers and making this tool fully opensource. >> > > > >> > > > So please proceed with distributive build. >> > > > >> > > > Best Regards, >> > > > Dmitriy Palvov >> > > > >> > > > >> > > > On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov >> > > > <dpavlov....@gmail.com> >> > > > wrote: >> > > > >> > > >> >> > > >> >> > > >> ---------- Forwarded message --------- >> > > >> From: Andrey Gura <ag...@apache.org> >> > > >> Date: ср, 4 апр. 2018 г. в 12:05 >> > > >> Subject: Re: abbrevation rules plugin >> > > >> To: <dev@ignite.apache.org> >> > > >> >> > > >> >> > > >> Both prefixes "Grid" and "Ignite" in class names are redundant for >> > most >> > > >> cases. So there is no any rules for this. >> > > >> >> > > >> вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur <daradu...@gmail.com>: >> > > >> >> > > >> > Hi, Igniters! >> > > >> > >> > > >> > I got into the task [1] in agreement with Dmitry. >> > > >> > >> > > >> > I’ve prepared the PR [2] with following changes: >> > > >> > - added Apache 2.0 license to the header of each file >> > > >> > - replaced prefix ‘Grid’ by ‘Ignite’ in class names >> > > >> > - added README.md with a simple description >> > > >> > - changed version 2.6.3 -> 3.0.0 because the project has own >> > > >> > GitHub >> > > >> > releases tab and completely new versioning isn't preferable IMO >> > > >> > >> > > >> > Also, I’ve built new artifact and tested it, it works well. >> > > >> > >> > > >> > Am I understood the task correct? >> > > >> > If not, please share your notes I will fix them shortly. >> > > >> > >> > > >> > As far as I understand someone of GridGain employee should >> > > >> > confirm >> > the >> > > >> > plugin's code's donation. It’d be great to confirm that by >> > > >> > corporate >> > > >> > email. >> > > >> > >> > > >> > >> > > >> > [1] https://issues.apache.org/jira/browse/IGNITE-5698 >> > > >> > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/1 >> > > >> > >> > > >> > >> > > >> > On Thu, Jul 6, 2017 at 12:30 PM, Dmitry Pavlov < >> > dpavlov....@gmail.com >> > > > >> > > >> > wrote: >> > > >> > > Hi Dmitriy, Denis, >> > > >> > > >> > > >> > > Thank you for your effort to find out solution. >> > > >> > > It sound good for me, I have assigned IGNITE-5698 to myself. >> > > >> > > >> > > >> > > Best Regards, >> > > >> > > Dmitriy Pavlov >> > > >> > > >> > > >> > > >> > > >> > > чт, 6 июл. 2017 г. в 2:45, Denis Magda <dma...@apache.org>: >> > > >> > > >> > > >> > >> Dmitriy P., >> > > >> > >> >> > > >> > >> Does it sound good to you? If yes, please make sure the plugin >> > > >> > >> is >> > > >> > >> available via a public GitHub repo and refer to it from the >> > > >> > >> doc. >> > > >> > >> >> > > >> > >> — >> > > >> > >> Denis >> > > >> > >> >> > > >> > >> > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan < >> > > >> dsetrak...@apache.org> >> > > >> > >> wrote: >> > > >> > >> > >> > > >> > >> > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda >> > > >> > >> > <dma...@apache.org >> > > >> > > >> > wrote: >> > > >> > >> > >> > > >> > >> >> Ok, what if we make sure the plugin is available on GitHub >> > (not >> > > >> > Ignite) >> > > >> > >> >> and give a link to it on the documentation page? This seems >> > > >> > >> >> to >> > > be >> > > >> the >> > > >> > >> >> easiest way to handle the topic. >> > > >> > >> > >> > > >> > >> > >> > > >> > >> > I think this will work. >> > > >> > >> >> > > >> > >> >> > > >> > >> > > >> > >> > > >> >> > > >> > >> > > >> > -- >> > > >> > Best Regards, Vyacheslav D. >> > > >> > >> > > >> >> > > > >> > > >> > -- Best Regards, Vyacheslav D.
