Hi Igniters, Was it ever discussed we stop to require TC to be passed with PR?
I insist we keep this sentence here: - Any change that touches code or test, whether reviewed or not, must have full TeamCity CI <http://ci.ignite.apache.org/>test suite pass. Sincerely, Dmitriy Pavlov ---------- Forwarded message --------- From: Vladimir Ozerov (Confluence) <conflue...@apache.org> Date: ср, 23 мая 2018 г. в 16:10 Subject: [CONF] Apache Ignite > How to Contribute To: <dpavlov....@gmail.com> There's *1 new edit* on this page [image: page-icon.png] <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute?src=mail&src.mail.product=confluence-server&src.mail.timestamp=1527081003738&src.mail.notification=com.atlassian.confluence.plugins.confluence-notifications-batch-plugin%3Abatching-notification&src.mail.recipient=8aa980875b5738b9015bbbaee5d401e3&src.mail.action=view> How to Contribute <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute?src=mail&src.mail.product=confluence-server&src.mail.timestamp=1527081003738&src.mail.notification=com.atlassian.confluence.plugins.confluence-notifications-batch-plugin%3Abatching-notification&src.mail.recipient=8aa980875b5738b9015bbbaee5d401e3&src.mail.action=view> [image: avatar_9a795451037091d2a0feba74463c9e49.png] Vladimir Ozerov edited this page Here's what changed: ... - Ignite employs both Review-Then-Commit (RTC) process for most of the components and Commit-Then-Review (CTR) for few ones. - Any change that touches code or test, whether reviewed or not, must have full TeamCity CI <http://ci.ignite.apache.org>test suite pass. - As a guideline, trivial changes, like updates to documentation or tests, etc. should not need a review prior to committing, and often can be made directly in the master branch.Please consult to Review Checklist <https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=85463936> to understand how tickets are reviewed and what rules to follow. Info title Master Branch Ignite "master" branch should always be *release-ready*. Please avoid any commits or merges to the "master" branch unless the whole TeamCity CI <http://ci.ignite.apache.org> suite has passed. ... Info title Optional: Tips to pass review quickly Ask commiter to review changes directly. Check affected files git history to find person most likely able to review changes. In case it's hard to determine who's able to review by git history use maintainers list presented above. Add "review request" comment to the Jira Issue starting with a commiter username. for example: "[~avinogradov], Please review my changes." Commiter will gain notification and review your changes and/or help to find another commiter to do this. Reviewing a Ticket - Make sure that your patch satisfies Review Checklist <https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=85463936> rules. - Each comment should be started with [~username] to guarantee proper notification. - Commiter should add comment like "Changes accepted and ready to be merged." once review successfully finished. - If the commiter/contributor has proposals, it is recommended to add a comment in the ticket in addition to PR / CR comments referring proposals added. This helps other committers to identify that fix has something to improve. ... Go to page history <https://cwiki.apache.org/confluence/pages/viewpreviousversions.action?pageId=57905110&src=mail&src.mail.product=confluence-server&src.mail.timestamp=1527081003738&src.mail.notification=com.atlassian.confluence.plugins.confluence-notifications-batch-plugin%3Abatching-notification&src.mail.recipient=8aa980875b5738b9015bbbaee5d401e3> View page <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute?src=mail&src.mail.product=confluence-server&src.mail.timestamp=1527081003738&src.mail.notification=com.atlassian.confluence.plugins.confluence-notifications-batch-plugin%3Abatching-notification&src.mail.recipient=8aa980875b5738b9015bbbaee5d401e3&src.mail.action=view> Stop watching page <https://cwiki.apache.org/confluence/users/removepagenotification.action?pageId=57905110&src=mail&src.mail.product=confluence-server&src.mail.timestamp=1527081003738&src.mail.notification=com.atlassian.confluence.plugins.confluence-notifications-batch-plugin%3Abatching-notification&src.mail.recipient=8aa980875b5738b9015bbbaee5d401e3&src.mail.action=stop-watching&jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ4c3JmOjhhYTk4MDg3NWI1NzM4YjkwMTViYmJhZWU1ZDQwMWUzIiwicXNoIjoiNTU0YWFiMmVhMzM2MmRmYThkOTUyYjViNDg3YTdhNmYxZmQ1ZjRhYWRiNDcxYTIzNTgzN2Y5MzU4NmNjOGRkYiIsImlzcyI6ImNvbmZsdWVuY2Vfbm90aWZpY2F0aW9uc0FSRUgtWFVEMS1QT1FHLUNTQU8iLCJleHAiOjE1Mjc2ODU4MDMsImlhdCI6MTUyNzA4MTAwM30.WG7u7ND4sdvpcBg4-2OqH7ax8rtNtMAA4X8xE0rsWYM> • Manage notifications <https://cwiki.apache.org/confluence/users/editmyemailsettings.action?src=mail&src.mail.product=confluence-server&src.mail.timestamp=1527081003738&src.mail.notification=com.atlassian.confluence.plugins.confluence-notifications-batch-plugin%3Abatching-notification&src.mail.recipient=8aa980875b5738b9015bbbaee5d401e3&src.mail.action=manage> [image: footer-desktop-logo.png] This message was sent by Atlassian Confluence 6.9.0 [image: footer-mobile-logo.png]
