Hi Pavel, Unfortunately the time that I now can dedicate to the community is very limited.
I would be happy if Ilya K. agrees to make a separate test in Java. Best Regards, Pavlov Dmitry вт, 29 мая 2018 г. в 21:19, Pavel Tupitsyn <ptupit...@apache.org>: > Sorry for the late notice, but there are no tests in that PR, so the > regression is possible again. > Let's not rely on .NET tests for this. > > On Tue, May 29, 2018 at 5:14 PM, Dmitry Pavlov <dpavlov....@gmail.com> > wrote: > > > Hi Igniters, Pavel, Ilya, > > > > Ilya's fix is merged to master. Ilya, thank you for contribution. > > > > Tests seems to be passing now. The only one left > > is DataRegionMetricsTest.TestMemoryMetrics, probably failed by > > IGNITE-8583. > > > > And I've also added dependency from Run All Basic to Platform .NET, so > > these tests will be executed on per-commit basis. > > > > Sincerely, > > Dmitriy Pavlov > > > > вт, 29 мая 2018 г. в 10:49, Pavel Tupitsyn <ptupit...@apache.org>: > > > > > Dmitry, the fix looks good to me, I would appreciate if you merge it. > > > > > > Thanks, > > > Pavel > > > > > > On Tue, May 29, 2018 at 12:02 AM, Dmitry Pavlov <dpavlov....@gmail.com > > > > > wrote: > > > > > > > Hi Pavel, > > > > > > > > Thank you for pointing to this. We've noticed that, and Ilya K. has > > > already > > > > prepared the fix, > > > > https://issues.apache.org/jira/browse/IGNITE-8604 > > > > https://github.com/apache/ignite/pull/4072 > > > > > > > > If you have some time you can apply the PR, or I will merge it later. > > > > > > > > Sincerely, > > > > Dmitriy Pavlov > > > > > > > > пн, 28 мая 2018 г. в 23:45, Pavel Tupitsyn <ptupit...@apache.org>: > > > > > > > > > Hi Dmirty, > > > > > > > > > > IGNITE-5789 merge [1] introduces this bug: > > > > > > > > > > Additional cache is being started from a template (cache name ends > > with > > > > *). > > > > > Normally template caches are only started when a cache with > matching > > > name > > > > > has been requested. > > > > > > > > > > Pavel > > > > > > > > > > [1] > > > > > > > > > > https://github.com/apache/ignite/commit/ > > d821d0999749a1be318a2106d73654 > > > > 2272a42ab0 > > > > > > > > > > On Fri, May 25, 2018 at 8:23 PM, Dmitriy Setrakyan <d...@gridgain.com > > > > > > wrote: > > > > > > > > > > > Hi Pavel, can you please respond here? > > > > > > > > > > > > ---------- Forwarded message ---------- > > > > > > From: Dmitry Pavlov <dpavlov....@gmail.com> > > > > > > Date: Fri, May 25, 2018 at 5:08 AM > > > > > > Subject: Platform .NET add to RunAll Basic suite > > > > > > To: dev <dev@ignite.apache.org> > > > > > > > > > > > > > > > > > > Hi Igniters, > > > > > > > > > > > > recently we've got 60-70 new test failures in .NET > > > > > > > > > > > > For me it is not simple to say which commit has failed build, so > I > > > > > suggest > > > > > > the following: > > > > > > > > > > > > 1. Add Platform .NET tests to run-all basic, it will be started > by > > > > > > per-VCS-commit basis. Per commit run will indicate change which > > > failed > > > > > the > > > > > > build. > > > > > > > > > > > > 2. Find out and mute flaky tests with tickets (if any). > > > > > > > > > > > > WDYT? > > > > > > > > > > > > Sincerely, > > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > > > > > > > > > > > > > >
