Amir, Anton, How is dev/review process going? Is there any chance we get this capability into 2.7?
-- Denis On Mon, Jul 9, 2018 at 10:27 PM Amir Akhmedov <amir.akhme...@gmail.com> wrote: > Hi Anton, > > I checked your last comments in the ticket and left some responses. Please > check them and let me know > > Thanks, > Amir > > P.S. do you mind to have a chat/call through gitter/Skype to discuss the > details? Sometimes 5 minutes of chat can be more productive than long > running email chains. Please, do not hesitate to directly email me if you > mind to have a chat/call. > > On Wed, Jun 27, 2018 at 11:26 AM Anton Vinogradov <a...@apache.org> wrote: > > > Sure, > > Hope it will be tomorrow > > > > ср, 27 июн. 2018 г. в 18:11, Amir Akhmedov <amir.akhme...@gmail.com>: > > > > > Anton V, > > > I put some comments into jira ticket. Can you please take a look once > you > > > have a chance? > > > > > > Thanks, > > > Amir > > > > > > On Mon, Jun 18, 2018, 7:54 AM Anton Vinogradov <a...@apache.org> wrote: > > > > > > > Amir, > > > > > > > > Everything is fine, I'll check changes this week. > > > > > > > > вс, 17 июн. 2018 г. в 6:09, Amir Akhmedov <amir.akhme...@gmail.com>: > > > > > > > > > Anton, > > > > > I created a news PR [1]. Since it includes the same changes I did > not > > > run > > > > > TC tests on it. Please let me know if you think otherwise. > > > > > > > > > > [1] https://github.com/apache/ignite/pull/4207 > > > > > > > > > > Thanks, > > > > > Amir > > > > > > > > > > > > > > > On Wed, Jun 13, 2018 at 8:38 AM Anton Vinogradov <a...@apache.org> > > > wrote: > > > > > > > > > > > Amir, > > > > > > > > > > > > Thanks for attempt. > > > > > > As far as I can see you have all changes at this commit: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/ignite/pull/3926/commits/cd0e50e05d3860788378ebf1a29dc0525460872a > > > > > > > > > > > > You can simply apply it to local branch based on master by patch > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/ignite/commit/cd0e50e05d3860788378ebf1a29dc0525460872a.patch > > > > > > > > > > > > In case you use IDEA, just apply patch from clipboard, and that's > > > will > > > > be > > > > > > you PR. > > > > > > > > > > > > BTW, next time you can use easiest way to squash your changes - > > just > > > to > > > > > > pull all changes from existing PR with squash > > > > > > > git pull https://github.com/apache/ignite.git pull/XXX/head > > > --squash > > > > > > > > > > > > > > > > > > > > > > > > вт, 5 июн. 2018 г. в 19:34, Amir Akhmedov < > amir.akhme...@gmail.com > > >: > > > > > > > > > > > > > Dmitry P., Anton V., > > > > > > > I made some changes and updated the ticket. Also as was asked I > > > tried > > > > > to > > > > > > > squash the commits into one but looks like I screwed up > > everything > > > > and > > > > > > the > > > > > > > PR now looks completely terrible. Since I'm not an advanced git > > > user, > > > > > > could > > > > > > > you please check the PR and let me know if anything could be > done > > > > > there? > > > > > > If > > > > > > > not I will try to create a new PR. > > > > > > > > > > > > > > Thanks, > > > > > > > Amir > > > > > > > > > > > > > > On Tue, May 29, 2018 at 10:37 AM, Dmitry Pavlov < > > > > dpavlov....@gmail.com > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi Amir, > > > > > > > > > > > > > > > > As far as I know, several Igniters provided some feedback in > > > > ticket. > > > > > > Are > > > > > > > > you agree? > > > > > > > > > > > > > > > > Sincerely, > > > > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > > > чт, 10 мая 2018 г. в 20:01, Dmitry Pavlov < > > dpavlov....@gmail.com > > > >: > > > > > > > > > > > > > > > > > Hi Amir, > > > > > > > > > > > > > > > > > > This is a very necessary contribution, the patch defenetely > > > will > > > > > not > > > > > > be > > > > > > > > > ignored. > > > > > > > > > > > > > > > > > > Igniters, > > > > > > > > > > > > > > > > > > Who can make a review from the committers? > > > > > > > > > > > > > > > > > > Sincerely, > > > > > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > > > > > вт, 8 мая 2018 г. в 5:52, Amir Akhmedov < > > > amir.akhme...@gmail.com > > > > >: > > > > > > > > > > > > > > > > > >> Hi Igniters, > > > > > > > > >> > > > > > > > > >> Can someone take a look at this PR please? > > > > > > > > >> > > > > > > > > >> Thanks, > > > > > > > > >> Amir > > > > > > > > >> > > > > > > > > >> On Mon, Apr 30, 2018 at 5:28 AM, Pavel Tupitsyn < > > > > > > ptupit...@apache.org > > > > > > > > > > > > > > > > >> wrote: > > > > > > > > >> > > > > > > > > >> > Hi Amir, > > > > > > > > >> > > > > > > > > > >> > I have filed [1] for multimap in .NET, it will be done > > > later. > > > > > > > > >> > In order to fix IgniteParityTest failures, please add > the > > > > > > following > > > > > > > to > > > > > > > > >> > MissingMembers array there: > > > > > > > > >> > > > > > > > > > >> > "multimap" // IGNITE-8425 > > > > > > > > >> > > > > > > > > > >> > Thanks, > > > > > > > > >> > Pavel > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > [1] https://issues.apache.org/jira/browse/IGNITE-8425 > > > > > > > > >> > > > > > > > > > >> > On Sun, Apr 29, 2018 at 11:32 PM, Amir Akhmedov < > > > > > > > > >> amir.akhme...@gmail.com> > > > > > > > > >> > wrote: > > > > > > > > >> > > > > > > > > > >> > > Hi Igniters, > > > > > > > > >> > > > > > > > > > > >> > > I raised a pull request [1] for Ignite multimap [2]. > TC > > > run > > > > > [3] > > > > > > > > seems > > > > > > > > >> ok > > > > > > > > >> > to > > > > > > > > >> > > me, some tests are failed though. Can someone review > it > > > > please > > > > > > and > > > > > > > > >> let me > > > > > > > > >> > > know? > > > > > > > > >> > > > > > > > > > > >> > > Thanks, > > > > > > > > >> > > Amir > > > > > > > > >> > > > > > > > > > > >> > > [1] https://github.com/apache/ignite/pull/3926 > > > > > > > > >> > > [2] https://issues.apache.org/jira/browse/IGNITE-640 > > > > > > > > >> > > [3] > > > > > > > > >> > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=1255210&ta > > > > > > > > >> > > > b=buildResultsDiv&buildTypeId=IgniteTests24Java8_RunAll > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
