Dimitiry, Re: IGNITE-9298 ... this is my first contribution, don't know who is reviewing the code, I did see that it was pulled by GridGain.
Additionally I was not happy about the test code, I followed what was there before but it doesn't seem right. On Thu, Sep 20, 2018 at 9:17 AM Dmitriy Pavlov <[email protected]> wrote: > Hi, > > As always, our constraint is a review. We as the community seems to agree > that review and patch commenting is a major contribution, but very few of > us doing a review, and 92 tickets are in Patch Available state. > > > https://cwiki.apache.org/confluence/display/IGNITE/Issues+waiting+for+review > > > Everyone can help, so tests run can be checked (e.g. in the TC Bot); code > style; change itself is clear and relates to issue. Don't forget to share > positive things that you like in PR/Change, does not point to problems > only. > > So if a ticket is accepted and merged there is usually no reason to move it > to the next version instead of the nearest one. > > Sincerely, > Dmitriy Pavlov > > чт, 20 сент. 2018 г. в 3:54, Ray <[email protected]>: > > > Hello, Igniters. > > > > Is there any specific reason why this ticket is removed from 2.7 scope? > > I think this ticket is important for both usability and performance. > > Without this ticket, we have to create an index manually identical to > > primary key if we want to use SQL query. > > https://issues.apache.org/jira/browse/IGNITE-8386 > > > > > > > > -- > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > >
