Hi Vladimir, https://issues.apache.org/jira/browse/IGNITE-9320 is named configuration finalization.
Why finalization was considered as done without tests passing? Why can't ve revert finalization change, re-do finalization with passing tests and merge changes? Sincerely, Dmitriy Pavlov пт, 28 сент. 2018 г. в 8:16, Vladimir Ozerov <voze...@gridgain.com>: > Test is going to be fixed in the scope of AI 2.7 [1]. This is not > one-minute fix as there are multiple places where configuration should be > passed, and changes should be covered with tests. I muted the test for now. > > [1] https://issues.apache.org/jira/browse/IGNITE-9390 > > On Fri, Sep 28, 2018 at 2:40 AM Dmitriy Setrakyan <dsetrak...@apache.org> > wrote: > > > Let's not revert any commits yet. Can we find out who did the commit and > > why he/she is not fixing the test? > > > > D. > > > > On Thu, Sep 27, 2018 at 4:21 PM Vyacheslav Daradur <daradu...@gmail.com> > > wrote: > > > > > Hi, > > > > > > Are you talking about > > > 'IgniteConfigurationParityTest#TestIgniteConfiguration'? > > > > > > Seems it's not hard to fix this test, it's necessary just to implement > > > missing members (at least as stubs) on .NET side in > > > IgniteConfiguration class. > > > > > > Is there a Jira issue? > > > > > > On Fri, Sep 28, 2018 at 2:12 AM Dmitriy Pavlov <dpavlov....@gmail.com> > > > wrote: > > > > > > > > Hi, > > > > > > > > I'm grateful for contributions made in that area, but it seems folks > > > don't > > > > have time to fix the test. > > > > > > > > > > > > Tomorrow I'm going to revert commit. > > > > > > > > It seems it is the only way we can keep master more or less green. > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=1888723&tab=buildChangesDiv&buildTypeId=IgniteTests24Java8_PlatformNet > > > > > > > > > > > > Sincerely > > > > Dmitry Pavlov > > > > > > > > > > > > -- > > > Best Regards, Vyacheslav D. > > > > > >
