Hi, I took a look at the code, and I believe the patch needs to be enhanced.
The patch is about adding TcpDiscoveryApplicationElbIpFinder, but it also deprecates the existing TcpDiscoveryElbIpFinder and replaces it with its copy named TcpDiscoveryClassicElbIpFinder. I’d really prefer if the existing class were enhanced to support both classic ELB and Application ELB. If it can’t be done, let’s use inheritance to reduce the copypaste. In any case, let’s avoid deprecating the existing class – I don’t think that changing the name is that important in this case. Thanks, Stan From: Denis Magda Sent: 26 сентября 2018 г. 18:52 To: dev Subject: Re: Volunteer needed: AWS Elastic Load Balancer IP Findersimplemented Igniters, Don't we have experts in our networking component? I do believe that's a small improvement that can be verified and merged quickly. -- Denis On Wed, Sep 26, 2018 at 8:50 AM Dmitriy Pavlov <dpavlov....@gmail.com> wrote: > Igniters, Friendly reminder. > > Denis, could you advice how to proceed in this case? It seems feature can > be useful, but committers are not involved in a review. > > Should we send a proposal with lazy consensus and automatically merge? Any > alternative ideas on how to proceed with issues stuck in the review process > are strongly appreciated. > > Sincerely, > Dmitriy Pavlov > > ср, 15 авг. 2018 г. в 19:38, Dmitriy Pavlov <dpavlov....@gmail.com>: > > > Hi Igniters, > > > > I took a look at the proposed contribution > > https://issues.apache.org/jira/browse/IGNITE-8617 and PR > > https://github.com/apache/ignite/pull/4076. > > > > I found this change reasonable and I can update code according to code > > style. > > > > But I would ask someone from the community with experience with AWS ELB > to > > join the review. It would also benefit us if someone could try to run a > > cluster with AWS ELB IP Finder. > > > > Sincerely, > > Dmitriy Pavlov > > >
