SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229284314
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/TcHelper.java
##########
@@ -144,44 +160,51 @@ private BranchesTracked getTrackedBranches() {
List<BuildRef> builds =
teamcity.getFinishedBuildsIncludeSnDepFailed(buildTypeId, branchForTc);
if (builds.isEmpty())
- return "JIRA wasn't commented - no finished builds to analyze.";
+ return new Visa().setStatus("JIRA wasn't commented - no finished
builds to analyze.");
BuildRef build = builds.get(builds.size() - 1);
- String comment;
+
+ List<SuiteCurrentStatus> suitesStatuses;
+
+ JiraCommentResponse response;
try {
- comment = generateJiraComment(buildTypeId, build.branchName,
srvId, prov, build.webUrl);
+ suitesStatuses = getSuitesStatuses(buildTypeId, build.branchName,
srvId, prov);
+
+ String comment = generateJiraComment(suitesStatuses, build.webUrl);
+
+ response = objectMapper.readValue(teamcity.sendJiraComment(ticket,
comment),
+ JiraCommentResponse.class);
Review comment:
Remove empty line before closing brace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
