SomeFire commented on a change in pull request #74: IGNITE-10275 Refactor of
visa caching. Jira spam fix.
URL: https://github.com/apache/ignite-teamcity-bot/pull/74#discussion_r234601602
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
##########
@@ -56,10 +59,20 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
+import static org.apache.ignite.ci.observer.BuildsInfo.CANCELLED_STATUS;
+import static org.apache.ignite.ci.observer.BuildsInfo.FINISHED_STATUS;
+import static org.apache.ignite.ci.observer.BuildsInfo.RUNNING_STATUS;
+
/**
* Provides method for TC Bot Visa obtaining
*/
public class TcBotTriggerAndSignOffService {
+ /** */
+ private static final ThreadLocal<DateFormat> THREAD_FORMATTER = new
ThreadLocal<DateFormat>() {
Review comment:
Why thread local? Looks like we need a simple object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
