SomeFire commented on a change in pull request #76: IGNITE-10275 Refactor of
visa caching.
URL: https://github.com/apache/ignite-teamcity-bot/pull/76#discussion_r235369867
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
##########
@@ -299,6 +294,12 @@ public SimpleResult commentJiraEx(
if (!Strings.isNullOrEmpty(ticketFullName)) {
BuildsInfo buildsInfo = new BuildsInfo(srvId, prov,
ticketFullName, branchForTc);
+ VisaRequest lastVisaReq =
visasHistoryStorage.getLastVisaRequest(buildsInfo.getContributionKey());
+
+ if (Objects.nonNull(lastVisaReq) && lastVisaReq.isObserving())
+ return new SimpleResult("Jira wasn't commented. \"Re-run
possible blockers & Comment JIRA\" was triggered for current branch." +
Review comment:
```suggestion
return new SimpleResult("Jira wasn't commented." +
+ " \"Re-run possible blockers & Comment JIRA\" was
triggered for current branch." +
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
